Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions docs/data/about/teamMembers.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,6 @@
"github": "Janpot",
"twitter": null
},
{
"name": "José Freitas",
"title": "Technical Product Manager",
"about": "Art, fiction, and bar philosophy.",
"location": "Augsburg, Germany",
"locationCountry": "de",
"github": "joserodolfofreitas",
"twitter": "zehdefreitas"
},
{
"name": "Andrew Cherniavskyi",
"title": "Tech Lead — xGrid",
Expand Down Expand Up @@ -125,15 +116,6 @@
"github": "MBilalShafi",
"twitter": "MBilalShafi"
},
{
"name": "Albert Yu",
"title": "Software Engineer — Core",
"about": "Minimalist, dog lover 🏔🐕.",
"location": "Hong Kong",
"locationCountry": "hk",
"github": "mj12albert",
"twitter": "mj12albert"
},
{
"name": "Romain Grégoire",
"title": "Software Engineer — xGrid",
Expand Down Expand Up @@ -296,15 +278,6 @@
"github": "rita-codes",
"twitter": "rita_codes"
},
{
"name": "Connor Davis",
"title": "Software Engineer — Core",
"about": "Community gardener, non-profit organizer, and nature enthusiast.",
"location": "New York City, US",
"locationCountry": "us",
"github": "dav-is",
"twitter": "connordav_is"
},
{
"name": "Luis Vasallo",
"title": "Account Executive — Sales",
Expand Down
Binary file removed docs/public/static/branding/about/albert-yu.png
Binary file not shown.
Binary file removed docs/public/static/branding/about/connor-davis.png
Binary file not shown.
Binary file removed docs/public/static/branding/about/josé-freitas.png
Binary file not shown.
8 changes: 4 additions & 4 deletions packages/mui-material/src/ButtonGroup/ButtonGroup.js
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,8 @@ const ButtonGroup = React.forwardRef(function ButtonGroup(inProps, ref) {
color,
disabled,
disableElevation,
disableFocusRipple,
disableRipple,
disableFocusRipple: props.disableFocusRipple,
disableRipple: props.disableRipple,
fullWidth,
size,
variant,
Expand All @@ -280,8 +280,8 @@ const ButtonGroup = React.forwardRef(function ButtonGroup(inProps, ref) {
color,
disabled,
disableElevation,
disableFocusRipple,
disableRipple,
props.disableFocusRipple,
props.disableRipple,
fullWidth,
size,
variant,
Expand Down
91 changes: 88 additions & 3 deletions packages/mui-material/src/ButtonGroup/ButtonGroup.test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect } from 'chai';
import { createRenderer, screen } from '@mui/internal-test-utils';
import { createRenderer, screen, simulateKeyboardDevice, isJsdom } from '@mui/internal-test-utils';
import ButtonGroup, { buttonGroupClasses as classes } from '@mui/material/ButtonGroup';
import { ThemeProvider, createTheme } from '@mui/material/styles';
import Button, { buttonClasses } from '@mui/material/Button';
Expand Down Expand Up @@ -156,6 +156,90 @@ describe('<ButtonGroup />', () => {
expect(container.querySelector('.touchRipple')).to.equal(null);
});

it('applies a global disableRipple (MuiButtonBase.defaultProps) to grouped buttons', async () => {
const { container } = render(
<ThemeProvider
theme={createTheme({
components: { MuiButtonBase: { defaultProps: { disableRipple: true } } },
})}
>
<ButtonGroup>
<Button TouchRippleProps={{ classes: { root: 'touchRipple' } }}>Hello World</Button>
</ButtonGroup>
</ThemeProvider>,
);
await ripple.startTouch(screen.getByRole('button'));
expect(container.querySelector('.touchRipple')).to.equal(null);
});

it('explicit disableRipple on ButtonGroup overrides the global default', async () => {
const { container } = render(
<ThemeProvider
theme={createTheme({
components: { MuiButtonBase: { defaultProps: { disableRipple: true } } },
})}
>
<ButtonGroup disableRipple={false}>
<Button TouchRippleProps={{ classes: { root: 'touchRipple' } }}>Hello World</Button>
</ButtonGroup>
</ThemeProvider>,
);
await ripple.startTouch(screen.getByRole('button'));
expect(container.querySelector('.touchRipple')).not.to.equal(null);
});

// JSDOM doesn't support :focus-visible
it.skipIf(isJsdom())(
'applies a global disableFocusRipple (MuiButton.defaultProps) to grouped buttons',
async function test() {
const { container } = render(
<ThemeProvider
theme={createTheme({
components: { MuiButton: { defaultProps: { disableFocusRipple: true } } },
})}
>
<ButtonGroup>
<Button TouchRippleProps={{ classes: { ripplePulsate: 'pulsate-focus-visible' } }}>
Hello World
</Button>
</ButtonGroup>
</ThemeProvider>,
);
const button = screen.getByRole('button');

simulateKeyboardDevice();
await ripple.startFocus(button);

expect(container.querySelector('.pulsate-focus-visible')).to.equal(null);
},
);

// JSDOM doesn't support :focus-visible
it.skipIf(isJsdom())(
'explicit disableFocusRipple on ButtonGroup overrides the global default',
async function test() {
const { container } = render(
<ThemeProvider
theme={createTheme({
components: { MuiButton: { defaultProps: { disableFocusRipple: true } } },
})}
>
<ButtonGroup disableFocusRipple={false}>
<Button TouchRippleProps={{ classes: { ripplePulsate: 'pulsate-focus-visible' } }}>
Hello World
</Button>
</ButtonGroup>
</ThemeProvider>,
);
const button = screen.getByRole('button');

simulateKeyboardDevice();
await ripple.startFocus(button);

expect(container.querySelector('.pulsate-focus-visible')).not.to.equal(null);
},
);

it('should not be fullWidth by default', () => {
const { container } = render(
<ButtonGroup>
Expand Down Expand Up @@ -204,8 +288,9 @@ describe('<ButtonGroup />', () => {
expect(context.variant).to.equal('contained');
expect(context.size).to.equal('large');
expect(context.fullWidth).to.equal(false);
expect(context.disableRipple).to.equal(false);
expect(context.disableFocusRipple).to.equal(false);
// Unset ripple flags are not forwarded, so each child resolves its own default (#32970).
expect(context.disableRipple).to.equal(undefined);
expect(context.disableFocusRipple).to.equal(undefined);
expect(context.disableElevation).to.equal(false);
expect(context.disabled).to.equal(false);
expect(context.color).to.equal('primary');
Expand Down
Loading