Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to minkphp/webdriver-classic-driver#44 (comment)
AbstractConfignow readsWEB_FIXTURES_HOST,TEST_MACHINE_BASE_PATHandDRIVER_MACHINE_BASE_PATHthrough a newgetEnvVar()method:getenv()first, then$_SERVER.Right now a
<server>in a driver'sphpunit.xml.distoverwrites the same variable given from the shell/CI, so it can't be overridden without a customphpunit.xml. With this change:<server>keep working as before;<env>whenever they want (it doesn't write$_SERVER, so that only works after this change).Once this is merged, the draft PRs minkphp/webdriver-classic-driver#66 and minkphp/MinkSelenium2Driver#415 would use
getEnvVar()instead of reading$_SERVER, and replace all<server>with<env>in theirphpunit*.xmlfiles, with no commented-out<server>left.getenv()isn't thread safe, but this is test-suite code only, so I think that's fine here.Tested locally: all 4 combinations of XML value (set or not) and shell value (set or not), PHPStan, and the MinkBrowserKitDriver suite.
🤖 Generated with Claude Code