Repository navigation
test(e2e): isolate EP CLI invocations in subprocesses - #1418
Merged
Merged
Conversation
Qiong Wu (qiowu) (DingmaomaoBJTU)
approved these changes
Sep 15, 2026
Qiong Wu (qiowu) (DingmaomaoBJTU)
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the subprocess migration, existing CLI subprocess helpers, EP availability gates, and retained assertions. No blocking findings: perf still requires a clean exit and validates output JSON/monitor results; unsupported compilation still checks the expected error and source-model integrity. A local direct check of the new helper verified argument/timeout forwarding, nonzero-exit rejection, and stdout/stderr diagnostics; diff checking passed. All reported PR CI checks are green. The AMD VitisAI/MIGraphX hardware sequence was not rerun locally; this review does not claim native in-process EP coexistence is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading VitisAI before MIGraphX in a shared pytest process causes MIGraphX registration to fail, even though standalone CLI invocations succeed. This blocks the daily E2E pipeline with three perf failures and masks the expected unsupported-compilation error in one compile test.
Run the parametrized perf EP cases and the unsupported-compilation rejection cases through the real CLI in fresh Python processes. Keep the existing result checks, require the expected process exit, capture stdout/stderr on failure, and add brief comments documenting the EP loading interaction. No skips, xfails, or product-code changes are introduced.
Validation on the AMD agent with Python 3.11.14 / ORT 1.27.1:
This isolates CLI invocations to match terminal usage; it does not fix native EP coexistence within a single application process.