Skip to content

feat(skills): add model support contribution workflow - #1415

Merged
Qiong Wu (qiowu) (DingmaomaoBJTU) merged 2 commits into
mainfrom
ssss141414/add-adding-model-support-skill
Sep 17, 2026
Merged

Qiong Wu (qiowu) (DingmaomaoBJTU) merged 2 commits into
mainfrom
ssss141414/add-adding-model-support-skill

Conversation

@ssss141414

@ssss141414 ssss141414 commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • migrate the operational adding-model-support skill from gim-home/ModelKitArtifacts PR add LpNormalization #352; the imported corpus originated at 9b51a3ea025e4789cf00ba7a8cf0c7844e7e1de5, and shared workflow improvements are synchronized back to source commit c9903e407207cd7f43f95c71b31c1df02f04fe7d
  • preserve 45 workflow, agent, evaluation, model-knowledge, methodology, cleanup, and contract-test files while removing the unreferenced stale story snapshot
  • adapt active instructions to the repo-local skills/adding-model-support/ layout and preserve historical provenance
  • use a concise dispatcher plus explicit fresh-subagent, optional dependency, and fail-closed promotion contracts
  • align response evals with the active reviewer verdict contract

Validation

  • trigger metadata classified all 18 trigger fixtures correctly in an independent frontmatter-only smoke evaluation
  • response smoke evaluation correctly returned a normal-comment REQUEST_CHANGES verdict and ownership routing for a fixable compatibility break
  • passed all 5 promotion, dispatch, and reviewer contract assertions
  • passed Ruff check and format verification for the Python contract test
  • parsed all skill JSON and YAML frontmatter successfully
  • verified relative Markdown links, EOF newlines, trailing whitespace, no exact duplicate files, and git diff --check
  • compared both repositories: 45/45 paths match; the remaining nine content differences are intentional repository/dependency adaptations
  • full uv run pytest and pre-commit bootstrap were attempted but dependency downloads were blocked by a local PyPI TLS handshake failure; equivalent available checks were run offline

@ssss141414
ssss141414 requested a review from a team as a code owner September 13, 2026 13:49
@ssss141414
ssss141414 force-pushed the ssss141414/add-adding-model-support-skill branch from 5ecb93e to e3af9d0 Compare September 13, 2026 14:00

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the workflow entry/role contracts and the executable cleanup helper. All reported CI checks are green and the five promotion-contract tests passed locally with repository plugin requirements disabled (missing torch warning-filter warnings). A dry-run of the unmodified cleanup script reproduces the issue below, so I am withholding approval. No cleanup was executed and no PR files were changed.

Comment thread skills/adding-model-support/scripts/cleanup-run-cache.ps1 Outdated
@DingmaomaoBJTU
Qiong Wu (qiowu) (DingmaomaoBJTU) merged commit 07a97cd into main Sep 17, 2026
9 checks passed
@DingmaomaoBJTU
Qiong Wu (qiowu) (DingmaomaoBJTU) deleted the ssss141414/add-adding-model-support-skill branch September 17, 2026 08:35
Qiong Wu (qiowu) (DingmaomaoBJTU) added a commit that referenced this pull request Sep 18, 2026
## Summary

- check in the canonical `auto-optimize` Agent Skill from
`gim-home/ModelKitArtifacts@2bcf29d9150ab3af2909f3cc2a0b278d7ca2387d`
- adapt the repository-layout contract and register
`skills/auto-optimize/tests` in the existing CI matrix, following #1415
- normalize imported Python to this repository's Ruff policy while
preserving script interfaces and generated output
- close inherited fail-open validation paths for non-finite hotspot
evidence and quoted/escaped absolute reproduction paths

## Validation

- `uv run pytest skills/auto-optimize/tests --tb=short --no-cov` (`309
passed`)
- `uv run ruff check skills/auto-optimize`
- `uv run ruff format --check skills/auto-optimize`
- pre-commit hooks on all 13 target-adapted files
- all 7 bundled JSON documents parsed successfully
- all 29 pinned-source files are present; final diff is limited to the
skill and CI registration

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants