Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (3)
⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
alexdempster44
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105.
Problem
On case-sensitive filesystems (Linux, so most Docker images and CI runners),
flutter buildfails with:pubspec.yamldeclarespluginClass: BlinkIdFlutterPlugin, but the file on disk was namedBlinkidFlutterPlugin.kt, with a lowercaseiandd. The Kotlin class inside the file was already spelled correctly, so only the filename was wrong.Flutter resolves the main class through an exact, case-sensitive path lookup derived from
pluginClass. It does not scan the directory. macOS (APFS) and Windows (NTFS) silently tolerate the mismatch, which is why this never showed up in local development.This reproduces on both 8000.0.0 and 8001.0.0.
Change
Three renames under
BlinkID/android/src/main/kotlin/com/microblink/blinkid/flutter/, with no content changes:BlinkidFlutterPlugin.kt→BlinkIdFlutterPlugin.ktBlinkidDeserializationUtils.kt→BlinkIdDeserializationUtils.ktBlinkidSerializationUtils.kt→BlinkIdSerializationUtils.ktOnly the first rename fixes the bug. The other two were just renamed for consistency.