Repository navigation
[lexical-html][examples] Documentation Update: Fix dead lexical.dev doc links - #9937
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
…oc links The Extension docs moved from /docs/concepts/extensions to /docs/extensions/intro, and the serialization docs moved from /docs/concepts/serialization to /docs/serialization/. Both old URLs return 404.
farisbasha
requested review from
acywatson,
etrepum,
ivailop7,
potatowagon and
zurfyx
as code owners
November 17, 2026 20:33
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
There was a problem hiding this comment.
This change looks good to me, thanks for tracking these down. Both new targets match pages in the docs tree:
examples/markdown-editor/README.md:5andexamples/nextjs-code-shiki/README.md:5:/docs/extensions/introispackages/lexical-website/docs/extensions/intro.md("Lexical Extensions"), the entry page of the Extensions docs. There is nodocs/concepts/extensionspage and no redirect for that path inpackages/lexical-website/docusaurus.config.ts, so the old link could only 404.packages/lexical-html/README.md:8:docs/concepts/serialization.mdmoved todocs/serialization/serialization.mdin #8528. Docusaurus serves a page named after its folder as that folder's index, so/docs/serialization/is correct, and the docs site already links that route itself (for examplepackages/lexical-website/docs/concepts/nodes.mdx:287).- No changeset is needed. As CONTRIBUTING.md and the pull request template say, docs and examples need none, and the Changesets check does not count a package README as shipped source.
Optional, non-blocking: the "Test plan" section of AGENTS.md asks for the real before and after output instead of a description. For a link fix, the status line of each URL (for example curl -sI <url> | head -1) would be enough.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three README links to lexical.dev return 404 ("Page Not Found"):
examples/markdown-editor/README.mdandexamples/nextjs-code-shiki/README.mdlink tohttps://lexical.dev/docs/concepts/extensions. The Extension docs are now underdocs/extensions/, so this points tohttps://lexical.dev/docs/extensions/intro("Lexical Extensions").packages/lexical-html/README.mdlinks tohttps://lexical.dev/docs/concepts/serialization. That page is nowpackages/lexical-website/docs/serialization/serialization.md, served athttps://lexical.dev/docs/serialization/("Serialization & Deserialization").Changeset
None needed: README/example docs only, no change to what any package does.
Test plan
Before
The three old URLs show the lexical.dev "Page Not Found" page.
After
Both new URLs load the matching docs pages.