Repository navigation
[lexical-html] Documentation Update: fix dead lexical.dev docs links - #9935
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
The serialization and extensions docs moved out of /docs/concepts/, so these links return 404.
farisbasha
requested review from
acywatson,
etrepum,
ivailop7,
potatowagon and
zurfyx
as code owners
November 17, 2026 17:46
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
There was a problem hiding this comment.
Looks good, thanks for fixing these. All three old /docs/concepts/... URLs return 404 today, and the new targets resolve to the right pages: /docs/serialization/ is where the old serialization page moved in #8528, and /docs/extensions/intro is the Extensions intro. The site's own docs link both routes. No changeset is needed for README and example changes (CONTRIBUTING.md, "Changesets").
Two optional, non-blocking suggestions:
- Test plan format. AGENTS.md ("Commits and Pull Requests") and
.github/pull_request_template.mdask for### Beforeand### Aftersubsections with the real output pasted, not described. For a link fix, thecurl -s -o /dev/null -w '%{http_code}'output for the old and new URLs would do. - Same kind of dead link, outside this diff. The JSDoc on
exportJSONandimportJSONinpackages/lexical/src/LexicalNode.ts(lines 1777 and 1840) linkshttps://lexical.dev/docs/serialization/serialization#json, which also returns 404, becausedocs/serialization/serialization.mdis served as the folder index at/docs/serialization/. The working link ishttps://lexical.dev/docs/serialization/#json. That one is a source edit, so a separate follow-up is probably cleaner than widening this README-only PR.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three README links point to lexical.dev pages under
/docs/concepts/that no longer exist (404):packages/lexical-html/README.md: "Full documentation can be found here" →https://lexical.dev/docs/concepts/serialization. Now points to https://lexical.dev/docs/serialization/ (the "Serialization & Deserialization" page, frompackages/lexical-website/docs/serialization/).examples/markdown-editor/README.mdandexamples/nextjs-code-shiki/README.md: "Extension" →https://lexical.dev/docs/concepts/extensions. Now points to https://lexical.dev/docs/extensions/intro.Both new URLs return 200.
Changeset
None needed: README/example documentation only, no package code changes.
Test plan
Checked the old URLs return 404 and the new ones return 200 with curl. No code changed.