Skip to content

[lexical-html] Documentation Update: fix dead lexical.dev docs links - #9935

Open
farisbasha wants to merge 1 commit into
meta:mainfrom
farisbasha:docs-dead-concepts-links
Open

farisbasha wants to merge 1 commit into
meta:mainfrom
farisbasha:docs-dead-concepts-links

Conversation

@farisbasha

Copy link
Copy Markdown

Description

Three README links point to lexical.dev pages under /docs/concepts/ that no longer exist (404):

  • packages/lexical-html/README.md: "Full documentation can be found here" → https://lexical.dev/docs/concepts/serialization. Now points to https://lexical.dev/docs/serialization/ (the "Serialization & Deserialization" page, from packages/lexical-website/docs/serialization/).
  • examples/markdown-editor/README.md and examples/nextjs-code-shiki/README.md: "Extension" → https://lexical.dev/docs/concepts/extensions. Now points to https://lexical.dev/docs/extensions/intro.

Both new URLs return 200.

Changeset

None needed: README/example documentation only, no package code changes.

Test plan

Checked the old URLs return 404 and the new ones return 200 with curl. No code changed.

The serialization and extensions docs moved out of /docs/concepts/,
so these links return 404.
@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
lexical Ready Ready Preview Nov 17, 2026 5:48pm UTC
lexical-playground Ready Ready Preview Nov 17, 2026 5:48pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 17, 2026
@rootnode-bot

rootnode-bot Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 17, 2026, 5:54 PM UTC

@rootnode-bot rootnode-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing these. All three old /docs/concepts/... URLs return 404 today, and the new targets resolve to the right pages: /docs/serialization/ is where the old serialization page moved in #8528, and /docs/extensions/intro is the Extensions intro. The site's own docs link both routes. No changeset is needed for README and example changes (CONTRIBUTING.md, "Changesets").

Two optional, non-blocking suggestions:

  1. Test plan format. AGENTS.md ("Commits and Pull Requests") and .github/pull_request_template.md ask for ### Before and ### After subsections with the real output pasted, not described. For a link fix, the curl -s -o /dev/null -w '%{http_code}' output for the old and new URLs would do.
  2. Same kind of dead link, outside this diff. The JSDoc on exportJSON and importJSON in packages/lexical/src/LexicalNode.ts (lines 1777 and 1840) links https://lexical.dev/docs/serialization/serialization#json, which also returns 404, because docs/serialization/serialization.md is served as the folder index at /docs/serialization/. The working link is https://lexical.dev/docs/serialization/#json. That one is a source edit, so a separate follow-up is probably cleaner than widening this README-only PR.

Automated review (maintainer link)

This branch was successfully deployed

2 active deployments
Preview – lexical — 51d631c1 Deployed Nov 17, 2026 by vercel[bot]
Preview – lexical-playground — 51d631c1 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant