Repository navigation
[lexical-table] Bug Fix: use visual line detection instead of caret rect for cell exit in arrow key handling #9393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lou-magnenat
wants to merge
13
commits into
meta:main
Choose a base branch
from
Infomaniak:fix/table-caret-line-detection-soft-wrap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8ad923a
[lexical-table] Bug Fix: use visual line detection instead of caret r…
lou-magnenat 408d7e8
[lexical-table] Bug Fix: resolve ambiguous soft wrap caret affinity w…
lou-magnenat e259229
[lexical-table] Bug Fix: keep caret rect fallback in engines without …
lou-magnenat 3dba2d0
[lexical-table] Chore: make wrapped-cell arrow key tests independent …
lou-magnenat 4449daa
[lexical-table] Chore: document soft wrap detection limitations and s…
lou-magnenat 6eee84c
[lexical-table] Bug Fix: invalidate pending vertical exit on pointerdown
lou-magnenat ca2bd66
[lexical-table] Bug Fix: keep native descent into a nested table at w…
lou-magnenat 5ebccd9
[lexical-table] Chore: shorten getVisualLineRectAtCaret JSDoc
lou-magnenat 14fa534
[lexical-table] Bug Fix: invalidate pending vertical exit on keydown …
lou-magnenat 3ec41f5
[lexical-table] Chore: add changeset for soft wrap arrow key fix
lou-magnenat 9eb4a70
[lexical-table] Bug Fix: correct only the selection change the deferr…
lou-magnenat 50dfd10
[lexical-table] Chore: document first-row edge case in changeset veri…
lou-magnenat d57811c
[lexical-table] Chore: replace fixed test waits with deterministic ev…
lou-magnenat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@lexical/table': patch | ||
| --- | ||
|
|
||
| [fix] Arrow keys at a soft wrap in a table cell move to the right line or cell | ||
|
|
||
| Verify: in a table cell whose text wraps, put the caret at the start of the last visual line and press ArrowDown: it moves to the cell below. Put it at a wrap boundary and press ArrowUp: it moves up one visual line instead of jumping out of the table. In a first-row cell with nothing above the table, ArrowUp from the end of the first line moves to the start of that line and a second press leaves the table. Home, End and clicks on either side of the wrap keep their behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.