[WC-3297] Signature web#2138

Open

gjulivan wants to merge 8 commits intomainfrom

Collaborator

gjulivan commented Mar 16, 2026

Pull request type

Description

gjulivan requested a review from a team as a code owner

March 16, 2026 13:14

github-actions Bot added the signature-web label

gjulivan changed the title ~~Signature web~~ [WC-3297] Signature web

gjulivan force-pushed the signature-web branch from ebcf9cc to b0d9476 Compare

March 16, 2026 13:14

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/__tests__/AppEvents.spec.tsx Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/components/Alert.tsx Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/assets/Signature.icon.dark.svg

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/ui/SignaturePreview.css Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/assets/Signature.icon.dark.png Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/package.xml Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/Signature.editorConfig.ts Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/Signature.tsx Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/CHANGELOG.md

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/package.json Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/package.json

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/package.json Outdated

gjulivan force-pushed the signature-web branch 8 times, most recently from 1edd154 to c439717 Compare

March 26, 2026 08:45

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/components/Signature.tsx

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/README.md Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/package.json Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/package.json Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/mendix-pluggable-widgets-tools.tgz Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/Signature.xml Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/utils/customTypes.ts

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/utils/useResizeObserver.ts Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/utils/useSignaturePad.ts Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/utils/Utils.ts

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/Signature.tsx Outdated

gjulivan force-pushed the signature-web branch 7 times, most recently from f4f70c2 to bafb254 Compare

March 27, 2026 11:57

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/components/SizeContainer.ts Outdated

gjulivan force-pushed the signature-web branch 2 times, most recently from e84f8ad to d15e0e3 Compare

April 21, 2026 10:26

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/components/SizeContainer.tsx

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/utils/useSignaturePad.ts

+              import SignaturePad, { Options } from "signature_pad";
+              import { SignatureProps } from "./customTypes";
+              function usePrevious<T>(value: T): T | null {

Collaborator

iobuhov Apr 30, 2026

I don't understand why we need this hook. Why we need keep attribute in ref and use effect to update it?

Collaborator Author

gjulivan May 5, 2026

this is based on previous behavior.

we need the previous values of the attribute.
if "hasSignature" goes from true to false, then reset signature.

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/utils/dimensions.ts

gjulivan force-pushed the signature-web branch from d15e0e3 to 968a371 Compare

May 5, 2026 09:12

gjulivan added 8 commits

May 5, 2026 11:12


          feat(signature): initial version of signature web widget

cfc20f2


          feat(signature): refactoring and rearrange codes

a0f3c71


          chore: update signature widget

04d6992


          fix: add unit test

80d5e7a


          fix: update icons and code cleanup

2a81555


          fix: snapshot and test

0feb49a


          chore: update props and code cleanup

084ca3a


          fix: convert size container into jsx and add filename property

5c70f7e

gjulivan force-pushed the signature-web branch from 968a371 to 5c70f7e Compare

May 5, 2026 09:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels