Make Show page a clear exit from focused reading - #37
Merged
Merged
Conversation
The restore control is a centered floating pill with an expand icon, a short hint, and an Esc keycap so it is obvious how to bring the rest of the page back. Co-authored-by: Matt Hummel <matthummel@proton.me>
Hide the restore hint and Esc keycap below 600px, and make the chip fully opaque so the exit control stays readable. Co-authored-by: Matt Hummel <matthummel@proton.me>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Gives the focused-reading Show page control a proper UI: a centered floating pill with an expand-the-layout icon, a two-line label (Show page / Restores the rest of the page), and an Esc keycap. Hover/focus uses the moss accent; the keycap hides on coarse pointers. Escape still exits Focus.
This is the 1.6.13 follow-up to 1.6.12 (restore existed, but the in-header Focus pill was easy to miss).
Type of change
How was this tested?
npm run lint:jsandnpm run lint:cssonsrc/view.jsandsrc/style.scssnpm run buildcompiles cleanlyChecklist
npm run buildcompletes without errorsnpm run lint:jsandnpm run lint:csspassWP_DEBUGonnode_modules/orbuild/readme.txt/CHANGELOG.mdupdated if behavior changedtocguide(not a variable)