SOF-7926: generic InMemoryEntity - #280
Open
k0stik wants to merge 13 commits into
Open
Conversation
Compose system/hashed via esse c6c4d84b1, wire hashedEntityMixin on Material, and keep persisted hash in sync after basis/lattice mutations. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep Material structure-only; persist and refresh hash on MaterialHashed via basis/lattice setters.
Allow web-app Core* subclasses to widen schema via MaterialHashed<S> without redeclaring _json. Pin @mat3ra/code for NoInfer on InMemoryEntity. Co-authored-by: Cursor <cursoragent@cursor.com>
Rely on InMemoryEntity.toJSON for hash; type defaultMaterialConfig as Schema. Co-authored-by: Cursor <cursoragent@cursor.com>
Materials often omit basis.constraints (stored as a proto property); restoring optional constraints and ?? [] avoids fromObjects(undefined). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.