-
Notifications
You must be signed in to change notification settings - Fork 5
feat: HOMO/LUMO NB #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VsevolodX
wants to merge
16
commits into
main
Choose a base branch
from
feature/SOF-7959
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: HOMO/LUMO NB #351
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3dd4662
update: defect energy NB
VsevolodX 0e2f5e1
update: defect energy NB cleanup
VsevolodX c574b50
update: cleanup
VsevolodX 11d382d
Merge branch 'main' into feature/SOF-7917
VsevolodX 231d040
update: handle charge
VsevolodX e78e5d4
chore: remove useless
VsevolodX 93b4edc
chore: update pmg links
VsevolodX 36acfc2
chore: links forbidden
VsevolodX ea6986a
chore: cleanup
VsevolodX 98d7d58
chore: cleanup
VsevolodX 6b16884
Merge branch 'feature/SOF-7954' into feature/SOF-7917
VsevolodX a9fdf9a
update: use new helpers
VsevolodX 557e426
feat: HOMO/LUMO NB
VsevolodX e5e8e1f
Merge branch 'main' into feature/SOF-7959
VsevolodX ac26b58
update: correct nb
VsevolodX c5595cf
update: add H2O material
VsevolodX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| { | ||
| "name": "H2O", | ||
| "basis": { | ||
| "elements": [ | ||
| { | ||
| "id": 0, | ||
| "value": "O" | ||
| }, | ||
| { | ||
| "id": 1, | ||
| "value": "H" | ||
| }, | ||
| { | ||
| "id": 2, | ||
| "value": "H" | ||
| } | ||
| ], | ||
| "coordinates": [ | ||
| { | ||
| "id": 0, | ||
| "value": [ | ||
| 0.0, | ||
| 0.5, | ||
| 0.0 | ||
| ] | ||
| }, | ||
| { | ||
| "id": 1, | ||
| "value": [ | ||
| 0.043139, | ||
| 0.431029, | ||
| 0.043078 | ||
| ] | ||
| }, | ||
| { | ||
| "id": 2, | ||
| "value": [ | ||
| 0.036635, | ||
| 0.576406, | ||
| 0.035949 | ||
| ] | ||
| } | ||
| ], | ||
| "units": "crystal", | ||
| "labels": [], | ||
| "constraints": [] | ||
| }, | ||
| "lattice": { | ||
| "a": 10.58354, | ||
| "b": 10.58354, | ||
| "c": 12.70025, | ||
| "alpha": 90.0, | ||
| "beta": 90.0, | ||
| "gamma": 90.0, | ||
| "units": { | ||
| "length": "angstrom", | ||
| "angle": "degree" | ||
| }, | ||
| "type": "TRI" | ||
| }, | ||
| "isNonPeriodic": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Synchronize the remaining Materials Project API-key references.
README.ipynb(Lines 83-91) andsrc/py/mat3ra/notebooks_utils/core/api/settings.py(Lines 9-18) still point to the legacy URL, so repository guidance is now inconsistent. Update those references or explicitly document why they must remain legacy.🤖 Prompt for AI Agents