Add ability to change append status when zipping files - #127
Open
AKoulabukhov wants to merge 1 commit into
Open
AKoulabukhov wants to merge 1 commit into
AKoulabukhov wants to merge 1 commit into
Conversation
… files to existing archives
AvdLee
requested changes
Jun 15, 2018
AvdLee
left a comment
AvdLee
left a comment
Collaborator
There was a problem hiding this comment.
I got some comments. Also; missing tests to verify the AppendStatus options are working. Can you add these? Thanks!
| public enum AppendStatus { | ||
| case create | ||
| case createAfter | ||
| case addinZip |
Collaborator
There was a problem hiding this comment.
Can we call this addInZip instead? As we Add In Zip, right?
| } | ||
| } | ||
|
|
||
| public enum AppendStatus { |
Collaborator
There was a problem hiding this comment.
Can you add some describing documentation to each case describing to the user what it does?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows to add files to existing archives using .addinZip status