Fill remaining AGENTS.md gaps in flutter, web, and store-locator skills - #85
Open
mattpodwysocki wants to merge 2 commits into
Open
mattpodwysocki wants to merge 2 commits into
mattpodwysocki wants to merge 2 commits into
Conversation
Fourth pass over the drop-in AGENTS.md files, covering the milder gaps
that survived measurement at n=5.
mapbox-web-integration-patterns never mentioned
`import 'mapbox-gl/dist/mapbox-gl.css'`, which appears 11 times across
its references. Without it the map still renders and nothing errors, so
the failure is silent: controls, popups and markers lose their styles.
Added as rule 0 of the Critical Integration Rules, since it applies to
every framework in the file.
mapbox-flutter-patterns showed `manager.tapEvents(...)` without the
`Cancelable` it returns, so the listener outlived the widget. Added the
stored subscription and `.cancel()` in `dispose`, plus a note that the
same pattern covers `longPressEvents`, `dragEvents` and the other
annotation managers. Also flagged the iOS deployment target as the single
most common iOS build failure, and that CocoaPods vs SPM is not a choice
the user has to make.
mapbox-store-locator-patterns omitted `highlightListing`, so selecting a
marker on the map highlighted a sidebar listing that could be off-screen.
Added it with the `scrollIntoView` call from SKILL.md, and gave the
listing element the `listing-${id}` id that the lookup depends on — the
existing snippet never set one.
mapbox-maplibre-migration said "Most Mapbox plugins work directly, no
alternatives needed", which reads as reassurance when the point is the
opposite: every `@maplibre/*` package generally needs a Mapbox
counterpart, and the table is not exhaustive.
Agents-surface, n=5 per eval:
flutter #3 57% -> 97% flutter #1 79% -> 96%
web-integration #1 80% -> 100% store-loc #1 70% -> 88%
store-locator #2 85% -> 97%
maplibre #3 moved 75% -> 82% but its spread widened to sd 0.171, so that
one is not cleanly attributable. store-locator #3 reads 93% -> 83%; it
covers GeolocateControl and geolocation, code this commit does not touch,
and the run ranges overlap (83-100 before, 75-100 after), so it is noise.
Deliberately excluded: mapbox-web-performance-patterns #2. It scores 80%
on BOTH surfaces, so it is not AGENTS.md drift. Its expectation says
75,000 points do not require clustering because "clustering is for
100,000+", while SKILL.md:175 says clustering is recommended from 10,000+.
The eval and the skill contradict each other and one of them is wrong;
that needs a domain decision, not an edit to make a score move.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mattpodwysocki
requested review from
underoot
and removed request for
a team
September 30, 2026 21:02
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth pass over the drop-in
AGENTS.mdfiles (after #83 and #84), covering the milder gaps that survived measurement at--repeats=5.mapbox-web-integration-patterns— the silent oneimport 'mapbox-gl/dist/mapbox-gl.css'appears 11 times across its references and zero times inAGENTS.md. Omit it and the map still renders, nothing throws, no console error — controls, popups and markers just lose their styles. Added as rule 0 of Critical Integration Rules since it applies to every framework in the file.mapbox-flutter-patternsmanager.tapEvents(...)was shown without theCancelableit returns, so the listener outlives the widget. Added the stored subscription and.cancel()indispose, plus a note thatlongPressEvents,dragEventsand the other annotation managers follow the same pattern.platform is lower than deployment target), and that CocoaPods vs SPM is not a decision the user has to make.mapbox-store-locator-patternshighlightListingwas missing, so selecting a marker highlighted a sidebar listing that could be off-screen. Added it with thescrollIntoViewcall fromSKILL.md— and gave the listing element thelisting-${id}id the lookup depends on, which the existing snippet never set.mapbox-maplibre-migrationThe note read "Most Mapbox plugins work directly, no alternatives needed" — reassurance, when the point is the opposite. Every
@maplibre/*package generally needs a Mapbox counterpart and the table is not exhaustive.Measured
Agents surface, n=5 per eval:
flutter#3flutter#1web-integration#1store-locator#1store-locator#2Two honest caveats.
maplibre#3 moved 75% → 82%, but its spread widened to sd 0.171, so that gain is not cleanly attributable. Andstore-locator#3 reads 93% → 83% — it coversGeolocateControland geolocation, code this commit does not touch, and the run ranges overlap (83–100 before, 75–100 after), so it is noise rather than a regression.Deliberately excluded:
web-performance#2It scores 80% on both surfaces, so it is not
AGENTS.mddrift. Its expectation states that 75,000 points do not require clustering because "clustering is for 100,000+", whileSKILL.md:175says clustering is recommended from 10,000+. The eval and the skill contradict each other, and one of them is wrong. That needs a domain decision — not an edit to make a number move.Ordering
Branches from
main; independent of #80, #83 and #84. The--surfaceand--repeatsflags used to measure this live in #80.🤖 Generated with Claude Code