[GIT-174]chore: set completed_at as read only field for work item#9083
[GIT-174]chore: set completed_at as read only field for work item#9083sangeethailango wants to merge 1 commit into
completed_at as read only field for work item#9083Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThree issue serializers ( ChangesProtect completed_at field from client writes
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Marks completed_at as read-only in Issue serializers so it cannot be set via API requests.
Changes:
- Add
completed_attoread_only_fieldsin app-level Issue serializer. - Add
completed_attoread_only_fieldsin API-levelIssueSerializerand another Meta block.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/api/plane/app/serializers/issue.py | Adds completed_at to read-only fields. |
| apps/api/plane/api/serializers/issue.py | Adds completed_at to read-only fields in two Meta classes. |
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
This pull request updates the serializers for the Issue model to include the completed_at field as read-only. This ensures that the completed_at timestamp cannot be modified directly through API requests, improving data integrity and consistency.
Summary by CodeRabbit