Skip to content

Animate success bar fully green at 100% chance #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Travja wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Animate success bar fully green at 100% chance #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/java/studio/magemonkey/divinity/manager/interactions/api/AnimatedSuccessBar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,11 @@ class Task extends ITask<Divinity> {

Task() {
super(AnimatedSuccessBar.this.plugin, AnimatedSuccessBar.this.fillInterval, true);
int calculatedResult = Math.round(Rnd.get(true));
int iterations = (int) Math.ceil(100D / fillAmount);
// Map the iteration to the relative success for the result
int iterations = (int) Math.ceil(100D / fillAmount);
// At 100% chance the bar should animate fully green — no red segments
int calculatedResult = (chance >= 100)
? iterations * fillAmount + 1
: Math.round(Rnd.get(true));
for (int i = 0; i < iterations; i++) {
mappedResult.add(i * fillAmount < calculatedResult);
}
Expand Down
Loading