Guard against empty projectile metadata lists - #330
Open
Travja wants to merge 1 commit into
Open
Conversation
hasMetadata()/getMetadata() are not atomic, so a projectile's metadata can be removed between the two calls (e.g. by another plugin or a concurrent listener). Check for an empty list before indexing into it instead of assuming a match is still present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #320 (piece 5/12, independent).
hasMetadata()/getMetadata()are not atomic, so a projectile's metadata can be removed between the two calls (e.g. by another plugin or a concurrent listener). Checks for an empty list before indexing into it instead of assuming a match is still present.Backward compatibility
None applicable — purely defensive; behavior on the happy path (metadata present) is unchanged.