Skip to content

Improve LLDP support - #1517

Open
larsstrandos wants to merge 5 commits into
lxc:mainfrom
larsstrandos:network-lldp
Open

larsstrandos wants to merge 5 commits into
lxc:mainfrom
larsstrandos:network-lldp

Conversation

@larsstrandos

Copy link
Copy Markdown

Improves LLDP on interfaces and bonds, so switches get useful port information and you can see which switch port a server is cabled to.

  • Receive-only mode: new lldp_receive_only option to learn about neighbors without announcing the system.
  • Port description: the interface or bond name is sent as the LLDP port description, instead of only the internal device name (such as _p52540012abcd).
  • Neighbor details: the LLDP state now includes the neighbor's system description, capabilities and port VLAN ID.
  • TUI: the footer lists LLDP neighbors, so you can see the switch and port from the console.
  • No device recreation: changing LLDP options no longer recreates the interface's or bond's devices, which dropped BGP sessions on the uplink for about a minute.
  • Docs: LLDP is documented.

Related to #1516.

Add an "lldp_receive_only" option to interfaces and bonds, to learn
about LLDP neighbors without announcing the system on the link.

Also report the neighbor's system description, capabilities and port
VLAN ID in the LLDP state.

Signed-off-by: Lars Strandos <lars@spanning.no>
The LLDP port ID that systemd-networkd sends is the name of the
underlying device, such as "_p52540012abcd", which doesn't tell the
switch administrator much. Set the interface or bond name as the
network's description, which networkd sends as the LLDP port
description.

Support the receive-only mode by setting LLDP= without EmitLLDP=, and
parse the system description, enabled capabilities and port VLAN ID of
neighbors.

Signed-off-by: Lars Strandos <lars@spanning.no>
List the LLDP neighbors of interfaces and bonds with LLDP reception
enabled, which helps find out which switch port a server is cabled to
from its console.

Signed-off-by: Lars Strandos <lars@spanning.no>
Signed-off-by: Lars Strandos <lars@spanning.no>
Changing the LLDP options of an interface or bond made IncusOS delete
and recreate its devices, as with any other change to its
configuration. On a host whose uplink carries BGP, that dropped the
sessions for about a minute, only to start announcing LLDP.

The LLDP options only change the physical devices' network files,
which systemd-networkd re-applies when it restarts, so ignore them
like the firewall rules and roles.

Signed-off-by: Lars Strandos <lars@spanning.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant