Repository navigation
Improve LLDP support - #1517
Open
larsstrandos wants to merge 5 commits into
Open
Improve LLDP support#1517larsstrandos wants to merge 5 commits into
larsstrandos wants to merge 5 commits into
Conversation
Add an "lldp_receive_only" option to interfaces and bonds, to learn about LLDP neighbors without announcing the system on the link. Also report the neighbor's system description, capabilities and port VLAN ID in the LLDP state. Signed-off-by: Lars Strandos <lars@spanning.no>
The LLDP port ID that systemd-networkd sends is the name of the underlying device, such as "_p52540012abcd", which doesn't tell the switch administrator much. Set the interface or bond name as the network's description, which networkd sends as the LLDP port description. Support the receive-only mode by setting LLDP= without EmitLLDP=, and parse the system description, enabled capabilities and port VLAN ID of neighbors. Signed-off-by: Lars Strandos <lars@spanning.no>
List the LLDP neighbors of interfaces and bonds with LLDP reception enabled, which helps find out which switch port a server is cabled to from its console. Signed-off-by: Lars Strandos <lars@spanning.no>
Signed-off-by: Lars Strandos <lars@spanning.no>
Changing the LLDP options of an interface or bond made IncusOS delete and recreate its devices, as with any other change to its configuration. On a host whose uplink carries BGP, that dropped the sessions for about a minute, only to start announcing LLDP. The LLDP options only change the physical devices' network files, which systemd-networkd re-applies when it restarts, so ignore them like the firewall rules and roles. Signed-off-by: Lars Strandos <lars@spanning.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves LLDP on interfaces and bonds, so switches get useful port information and you can see which switch port a server is cabled to.
lldp_receive_onlyoption to learn about neighbors without announcing the system._p52540012abcd).Related to #1516.