Skip to content

tests: pass on Python 3.10, macOS and hosts without QEMU - #74

Merged
paf0186 merged 1 commit into
masterfrom
ci-fixes
Nov 16, 2026
Merged

paf0186 merged 1 commit into
masterfrom
ci-fixes

Conversation

@paf0186

@paf0186 paf0186 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Master CI has failed since #70: three tests that only fail on CI.

  • `TestDisk::test_archived_target_counts_on_its_own_filesystem` (Python 3.10): the fake `Path.stat` called `Path.resolve()`, which calls `stat` itself before Python 3.13, so it recursed. It now uses `os.path.realpath`.
  • `test_usable_cpus_follows_affinity` (macOS): patched `os.sched_getaffinity`, which macOS lacks. Patched with `create=True`; the code already falls back to `os.cpu_count` there.
  • `TestRequirements::test_host_checks_read_qemu` (all): deleted the QEMU capability cache, which is only written when a QEMU binary exists to probe. Now `unlink(missing_ok=True)`.

Test-only. Full suite passes here (4724 passed); the three pass under Python 3.12 and 3.13.

🤖 Generated with Claude Code

Three tests failed in CI only. The archived-target disk test's fake
stat called Path.resolve, which calls stat itself before Python 3.13
and recursed. The CPU affinity test patched os.sched_getaffinity,
which macOS lacks. The shmrdma QEMU test removed a capability cache
that is only written when a QEMU binary exists to probe.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@paf0186
paf0186 merged commit e4b185b into master Nov 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant