[Repo Assist] perf: bulk memcpy/memset for %s padding and string copy in l_vsnprintf#137
Draft
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
38 tasks
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
Summary
Replace character-by-character loops in
l_vsnprintf's%spath with bulkl_memcpy/l_memsetcalls, giving O(n/word_size) throughput instead of O(n) for padded string printing.Root Cause
The
%sformat specifier's padding and copy loops usedL_SNPRINTF_EMITone character at a time, creating per-character overhead for potentially large strings.Fix
Replace with bounds-safe bulk operations using a
L_SNPRINTF_AVAIL()helper macro that preventssize_tunderflow whenn==0. Truncation and NUL termination semantics are preserved.Test Status
✅ Linux/gcc: build PASS, 1515 assertions PASS
✅ Linux/clang: build PASS, 1513 assertions PASS
✅ Verify: 52 binaries, max 117KB, static PASS