CI: run hererocks on multiple OSes and Lua and Luarocks versions - #57
CI: run hererocks on multiple OSes and Lua and Luarocks versions#57cclauss wants to merge 1 commit into
Conversation
Does this mean it is running hererocks from pypi instead of the version in the repo? We would want the ci here to run the version from the commit it is running on. |
|
- if: ${{ matrix.pypi }}
run: pipx run hererocks lua --lua=${{ matrix.luaVersion }} --luarocks=${{ matrix.luaRocksVersion }}
- if: ${{ !matrix.pypi }}
env:
SPEC: git+https://github.com/luarocks/hererocks.git
run: pipx run --spec=$SPEC hererocks lua --lua=${{ matrix.luaVersion }} --luarocks=${{ matrix.luaRocksVersion }}These commands are easy to run in your terminal if you have https://www.lua.org/versions.html % apt -q -q --yes update
DEBIAN_FRONTEND=noninteractive apt install --yes build-essential git libreadline-dev libssl-dev python3-venv unzip
python3 -m venv .venv
source .venv/bin/activate
pip install --upgrade pip
pip install pipx uv
uvx hererocks lua --lua=5.5 # Error: bad Lua version 5.5
uvx hererocks lua --lua=5.3 --luarocks=3.13.0 # Error: bad LuaRocks version 3.13.0
uvx hererocks lua --lua=latest --luarocks=latest # Lua 5.4.4 (not 5.5.1), LuaRocks 3.8.0 (not 3.13.0)
uvx hererocks lua --lua=5.4 --patch # Lua 5.4.4 (not 5.4.8)
uvx hererocks lua --lua=5.3 --patch # Lua 5.3.6 (correct)
uvx hererocks lua --lua=5.2 --patch # Lua 5.2.4 (correct)
uvx hererocks lua --lua=5.1 --patch # Lua 5.1.5 (correct) |
The 4 Ubuntu issues above are all fixed on
|
bc9e418 to
05a155b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
==========================================
+ Coverage 67.63% 68.77% +1.14%
==========================================
Files 1 1
Lines 1140 1140
==========================================
+ Hits 771 784 +13
+ Misses 369 356 -13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b281285 to
757d854
Compare
Mostly works as expected, but some lessons learned: * [ ] `hererocks lua --lua=5.5 ` # Fails * [ ] `hererocks lua --lua=5.4 --luarocks=latest ` # Installs luarocks 3.8.0, not 3.13.0 * [ ] `hererocks lua --lua=5.4 --luarocks=3.13.0 # Fails * [ ] `lua\bin\activate.bat ` # Windows fails to add 'lua/bin' to $PATH.
Mostly works as expected, but some lessons learned:
hererocks lua --lua=5.5# Failshererocks lua --lua=5.4 --luarocks=latest# Installs luarocks 3.8.0, not 3.13.0hererocks lua --lua=5.4 --luarocks=3.13.0# Failslua\bin\activate.bat# Windows fails to add 'lua/bin' to $PATH.