Skip to content

CI: run hererocks on multiple OSes and Lua and Luarocks versions - #57

Closed
cclauss wants to merge 1 commit into
luarocks:masterfrom
cclauss:patch-1
Closed

CI: run hererocks on multiple OSes and Lua and Luarocks versions#57
cclauss wants to merge 1 commit into
luarocks:masterfrom
cclauss:patch-1

Conversation

@cclauss

@cclauss cclauss commented Jul 5, 2026

Copy link
Copy Markdown

Mostly works as expected, but some lessons learned:

  • hererocks lua --lua=5.5 # Fails
  • hererocks lua --lua=5.4 --luarocks=latest # Installs luarocks 3.8.0, not 3.13.0
  • hererocks lua --lua=5.4 --luarocks=3.13.0 # Fails
  • lua\bin\activate.bat # Windows fails to add 'lua/bin' to $PATH.

@tobil4sk

tobil4sk commented Aug 1, 2026

Copy link
Copy Markdown

hererocks lua --lua=5.4 --luarocks=latest # Installs luarocks 3.8.0, not 3.13.0

Does this mean it is running hererocks from pypi instead of the version in the repo? We would want the ci here to run the version from the commit it is running on.

@cclauss

cclauss commented Aug 1, 2026

Copy link
Copy Markdown
Author

pypi: true -- Hererocks from PyPI demonstrates where the current end-user experience is broken.

pypi: false -- Once the PyPI experience is fixed, we can focus the workflow more on testing the local codebase.


- if: ${{ matrix.pypi }}
  run: pipx run hererocks lua --lua=${{ matrix.luaVersion }} --luarocks=${{ matrix.luaRocksVersion }}
- if: ${{ !matrix.pypi }}
  env:
    SPEC: git+https://github.com/luarocks/hererocks.git
  run: pipx run --spec=$SPEC hererocks lua --lua=${{ matrix.luaVersion }} --luarocks=${{ matrix.luaRocksVersion }}

These commands are easy to run in your terminal if you have pipx or uv installed.


https://www.lua.org/versions.html
https://github.com/luarocks/luarocks/releases

% docker run -it ubuntu:26.10 # also try 26.04, 24.04, etc.

apt -q -q --yes update
DEBIAN_FRONTEND=noninteractive apt install --yes build-essential git libreadline-dev libssl-dev python3-venv unzip
python3 -m venv .venv
source .venv/bin/activate
pip install --upgrade pip
pip install pipx uv

uvx hererocks lua --lua=5.5  # Error: bad Lua version 5.5
uvx hererocks lua --lua=5.3 --luarocks=3.13.0  # Error: bad LuaRocks version 3.13.0
uvx hererocks lua --lua=latest --luarocks=latest  # Lua 5.4.4 (not 5.5.1), LuaRocks 3.8.0 (not 3.13.0)
uvx hererocks lua --lua=5.4 --patch  # Lua 5.4.4 (not 5.4.8)

uvx hererocks lua --lua=5.3 --patch  # Lua 5.3.6 (correct)
uvx hererocks lua --lua=5.2 --patch  # Lua 5.2.4 (correct)
uvx hererocks lua --lua=5.1 --patch  # Lua 5.1.5 (correct)

@cclauss

cclauss commented Aug 4, 2026

Copy link
Copy Markdown
Author

The 4 Ubuntu issues above are all fixed on master:

REPO=git+https://github.com/luarocks/hererocks.git
uvx --from=REPO hererocks lua --lua=5.5  # Lua 5.5.1 (correct)
uvx --from=REPO hererocks lua --lua=5.3 --luarocks=latest  # Lua 5.3.6 (correct), LuaRocks 3.13.0 (correct)
uvx --from=REPO hererocks lua --lua=latest --luarocks=latest  # Lua 5.5.1 (correct), LuaRocks 3.13.0 (correct)
uvx --from=REPO hererocks lua --lua=5.4 --patch  # Lua 5.4.8 (correct)

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.77%. Comparing base (5c97cf1) to head (05a155b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   67.63%   68.77%   +1.14%     
==========================================
  Files           1        1              
  Lines        1140     1140              
==========================================
+ Hits          771      784      +13     
+ Misses        369      356      -13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cclauss
cclauss force-pushed the patch-1 branch 4 times, most recently from b281285 to 757d854 Compare August 4, 2026 23:52
Mostly works as expected, but some lessons learned:
* [ ] `hererocks lua --lua=5.5 ` # Fails
* [ ] `hererocks lua --lua=5.4 --luarocks=latest ` # Installs luarocks 3.8.0, not 3.13.0
* [ ] `hererocks lua --lua=5.4 --luarocks=3.13.0  # Fails
* [ ] `lua\bin\activate.bat ` # Windows fails to add 'lua/bin' to $PATH.
@cclauss cclauss closed this Aug 6, 2026
@cclauss
cclauss deleted the patch-1 branch August 6, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants