Repository navigation
Bump usb-device to v0.3; edition to 2024; release v0.7 - #93
Merged
Merged
Conversation
Contributor
|
My idea was to implement both at the same time instead of either-or. I’ll suggest a patch. |
Contributor
|
Why not just make it a breaking release and drop 0.2? |
robin-nitrokey
requested changes
Aug 20, 2026
robin-nitrokey
left a comment
robin-nitrokey
left a comment
Contributor
There was a problem hiding this comment.
As discussed, either support both versions in such a way that both can be used at the same time or drop support for the old version.
daringer
changed the title
Contributor
|
The easiest fix for the CI probably is to update the MSRV to 1.85. You could also update this crate to edition 2024 while you’re at it. |
Contributor
Author
|
done 🫡 |
daringer
changed the title
robin-nitrokey
approved these changes
Aug 24, 2026
Closed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EndpointType::Isochronousis usedcargo fmtfor edition 2024 wants to touch every file - it's a separate commit to mostly ignore it