Enable SW optimzation O1#549
Open
engdoreis wants to merge 7 commits into
Open
Conversation
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
This makes sure that bootrom logs don't interfer with tests. Also make sure that test logs are printed before the simulation is finished. Signed-off-by: Douglas Reis <doreis@lowrisc.org>
The test was sensitive to timing, when optimization was enabled it would fails as the loop back transmission would not have finished in time for checking. Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
The error manifest when optimization is enabled Signed-off-by: Douglas Reis <doreis@lowrisc.org>
engdoreis
force-pushed
the
optimize_sw
branch
2 times, most recently
from
f4b15db to
7fb7881
Compare
This makes binaries smaller and faster to run tests Signed-off-by: Douglas Reis <doreis@lowrisc.org>
engdoreis
requested review from
marnovandermaas and
ziuziakowska
and removed request for
ziuziakowska
ziuziakowska
approved these changes
May 20, 2026
| void *dv_test_status = mocha_system_dv_test_status(); | ||
|
|
||
| uart_init(console); | ||
| //Flush the uart |
Contributor
There was a problem hiding this comment.
Suggested change
| //Flush the uart | |
| // Flush the uart |
Comment on lines
+82
to
+89
| while (!uart_status_any(console, uart_status_txidle)) { | ||
| }; | ||
| DEV_WRITE(dv_test_status, TEST_STATUS_IN_TEST); | ||
|
|
||
| bool result = test_main(console); | ||
| //Flush the uart | ||
| while (!uart_status_any(console, uart_status_txidle)) { | ||
| }; |
Contributor
There was a problem hiding this comment.
Maybe this could be a uart_flush function in the HAL? Seems useful, and should maybe be called by uart_init too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also resolved some tests that failed due to timing issues triggered by the optimization.
Opensbi load before:
After:
fix #550