Add block information to the instrumentation job metadata#194
Open
AlexJones0 wants to merge 1 commit into
Open
Add block information to the instrumentation job metadata#194AlexJones0 wants to merge 1 commit into
AlexJones0 wants to merge 1 commit into
Conversation
Although it can currently be inferred/derived from the full name of the job, having the block (& block variant) information explicitly available in the recorded metadata is much more useful. This means that we can make visualizations and calculations of regression results partitioned by block or block variant. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
machshev
approved these changes
May 18, 2026
Collaborator
machshev
left a comment
machshev
left a comment
There was a problem hiding this comment.
Looks good, though I might prefer adding the whole block object (which is supposed to be block identifying meta data). At the moment it's maybe a bit heavy. But longer term I think we could deduplicate and move derived names to calculated properties. Which minimises serialised data size.
| job_type=spec.job_type, | ||
| target=spec.target, | ||
| tool=spec.tool.name, | ||
| block=spec.block.name, |
Collaborator
There was a problem hiding this comment.
Maybe rather than flattening just use composition and take the whole block meta data spec.block... that way if we update the block definition in some other way then this is constant without having to sync everything.
It does mean more information though and increased serialisation size perhaps?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the fifth of a series of PRs to introduce instrumentation reporting to DVSim.
A very simple addition - also capture the block & block variant alongside the existing metadata during instrumentation. Although this could technically be inferred from the full name of the job, having these fields explicitly available through a clear interface is much cleaner.
This will allow us to make visualizations / calculate metrics based on run results partitioned by block or block variant.