Skip to content

feat: one top bar for every narrow tab, clear of iPadOS window controls - #1680

Merged
lollipopkit merged 4 commits into
mainfrom
fix/ipados-window-controls
Oct 10, 2026
Merged

lollipopkit merged 4 commits into
mainfrom
fix/ipados-window-controls

Conversation

@lollipopkit

@lollipopkit lollipopkit commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Closes #1679

Summary

Changes

  • Window-controls inset reporting and layout integration: Adds iPadOS window-control zone reporting over a native method channel and applies the new fl_lib inset widget across app bars and rails.

@winnowl

winnowl Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Important

Review completed

Reviewed commit 17e9f64; the results are in the review on this pull request.

Merge risk: 🟢 Low · no blocking findings

Suggested reviewers: @yuguorui

📝 Walkthrough
  • Adaptive benchmark tab and list/detail navigation: Reworks the benchmark tab around split/single-column presentation, shared picker and history sheet, and SwitcherBar/SideBarActions; removes obsolete folding bar implementation and its test.
  • Remote desktop tab lifecycle and session switching: Changes remote desktop tab surface selection, session picker/switcher, and visibility/lifecycle handling.
  • Remote desktop viewer controls and input lifecycle: Updates the remote desktop viewer toolbar to shared SwitcherBar actions and maintains rendering, input, resize, and session transition behavior.
  • Virtualization create, guest, and resource navigation surfaces: Migrates virtualization create, guest, list, network, storage, and resource interfaces to the new switcher/action bar pattern and revises navigation and editing presentation.
  • Repository guidance for tab and UI conventions: Updates repository-level development guidance, including current tab-bar/layout conventions and workflow notes.
  • Review again

Commenting @winnowl review does the same.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 1f0c580e-a08d-499e-9eb7-48631618b769

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@winnowl

winnowl Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

CI failure root-cause analysis

The Windows CI failure is isolated to the server_box_monitor integration test seeing_and_controlling_need_virt_configuring_needs_admin in virt_api; all other reported test targets pass. The diagnostics do not include the assertion/panic details or a relevant diff, so the underlying cause and responsible change cannot be determined reliably.

Verifiable fix

Inspect the full failure output for seeing_and_controlling_need_virt_configuring_needs_admin, especially the panic/assertion and Windows-specific virtualization/admin checks. Make the test setup or implementation satisfy that observed expectation, then rerun cargo test -p server_box_monitor --test virt_api seeing_and_controlling_needs_virt_configuring_needs_admin on Windows and the full CI command.

Incremental value: root cause, verifiable fix; confidence 35%. Passing CI ≠ absence of defects (§29.4).

@lollipopkit
lollipopkit marked this pull request as ready for review October 10, 2026 10:44
winnowl[bot]
winnowl Bot previously approved these changes Oct 10, 2026

@winnowl winnowl Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

✅ No blocking issues found — approving.

ℹ️ Review info
⚙️ Run configuration

Configuration: defaults

Review profile: balanced

Model: gpt-6-luna

📥 Commits

Reviewing files that changed between 50e61ed and abcb90d.

⛔ Files not reviewed (1)
  • packages/fl_lib is skipped as submodule
📒 Files selected for processing (16)
  • ios/Runner.xcodeproj/project.pbxproj
  • ios/Runner/AppDelegate.swift
  • ios/Runner/WindowControls.swift
  • lib/core/chan.dart
  • lib/main.dart
  • lib/view/page/benchmark/tab.dart
  • lib/view/page/home/nav.dart
  • lib/view/page/server/tab/bar.dart
  • lib/view/page/server/tab/selection_bar.dart
  • lib/view/page/snippet/list.dart
  • lib/view/page/ssh/tab.dart
  • lib/view/page/storage/file_browser.dart
  • lib/view/page/storage/tab.dart
  • lib/view/page/virt/guest.dart
  • lib/view/page/virt/list.dart
  • lib/view/page/virt/resources.dart

Coverage

  • 1 of 1 areas reviewed

@lollipopkit lollipopkit changed the title fix: keep bars clear of iPadOS window controls feat: one top bar for every narrow tab, clear of iPadOS window controls Oct 10, 2026

@winnowl winnowl Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

✅ No blocking issues found — approving.

ℹ️ Review info
⚙️ Run configuration

Configuration: defaults

Review profile: balanced

Model: gpt-6-luna

📥 Commits

Reviewing files that changed between 50e61ed and 17e9f64.

28 file(s) unchanged since their last review were skipped.

⛔ Files not reviewed (1)
  • packages/fl_lib is skipped as submodule
📒 Files selected for processing (11)
  • CLAUDE.md
  • lib/view/page/benchmark/tab.dart
  • lib/view/page/remote_desktop/tab.dart
  • lib/view/page/remote_desktop/viewer.dart
  • lib/view/page/virt/create.dart
  • lib/view/page/virt/guest.dart
  • lib/view/page/virt/list.dart
  • lib/view/page/virt/network.dart
  • lib/view/page/virt/resources.dart
  • lib/view/page/virt/storage.dart
  • test/unit/remote_desktop/remote_desktop_viewer_test.dart
🚧 Files skipped as already reviewed (28)
  • ios/Runner.xcodeproj/project.pbxproj
  • ios/Runner/AppDelegate.swift
  • ios/Runner/WindowControls.swift
  • lib/core/chan.dart
  • lib/main.dart
  • lib/view/page/agent/agent.dart
  • lib/view/page/agent/history.dart
  • lib/view/page/agent/view.dart
  • lib/view/page/home/nav.dart
  • lib/view/page/server/tab/bar.dart
  • lib/view/page/server/tab/selection_bar.dart
  • lib/view/page/server/tab/sheets.dart
  • lib/view/page/server/tab/tab.dart
  • lib/view/page/server/tab/utils.dart
  • lib/view/page/snippet/list.dart
  • lib/view/page/ssh/tab.dart
  • lib/view/page/ssh/tab_add.dart
  • lib/view/page/storage/file_browser.dart
  • lib/view/page/storage/local.dart
  • lib/view/page/storage/server_file.dart
  • lib/view/page/storage/sftp.dart
  • lib/view/page/storage/tab.dart
  • lib/view/page/virt/tab.dart
  • lib/view/widget/nav_rail.dart
  • lib/view/widget/tag_switcher.dart
  • lib/view/widget/terminal_status_sheet.dart
  • test/widget/benchmark_resume_test.dart
  • test/widget/session_tab_bar_test.dart

Coverage

  • 5 of 5 areas reviewed

@lollipopkit
lollipopkit merged commit 76eb12a into main Oct 10, 2026
20 checks passed
@lollipopkit
lollipopkit deleted the fix/ipados-window-controls branch October 10, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] iPadOS 窗口化

1 participant