fix(android): forward requestDisallowInterceptTouchEvent in footer view - #766
Merged
Conversation
TrueSheetFooterView is the remaining RootView impl with the ViewGroup default: an EditText in the footer would set the footer's own disallow flag, blinding its jsTouchDispatcher to the gesture end and leaving a stale JS responder that swallows the next tap — same class of bug as the controller fix in #765. Mirror ReactSurfaceView: forward the request up without setting our own flag. Follow-up to #765
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lodev09
added a commit
that referenced
this pull request
Aug 9, 2026
lodev09
force-pushed
the
fix/android-footer-disallow-intercept
branch
from
August 9, 2026 07:17
becd7af to
b9a0933
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #765 (issue #764).
TrueSheetFooterViewis the remainingRootViewimplementation withViewGroup's defaultrequestDisallowInterceptTouchEvent(ReactViewGroupdoesn't override it). AnEditTextin the footer would set the footer's own disallow flag on touch, blinding itsjsTouchDispatcherto the gesture's UP — leaving a stale JS responder that swallows the next tap on a siblingPressablein the footer. Same class of bug as the controller fix in #765.Fix mirrors
ReactSurfaceView(and the controller): don't set the view's own disallow flag, forward the request up the tree — soTrueSheetCoordinatorLayoutstill receives it and its drag arbitration is unchanged.Type of Change
Test Plan
Same repro shape as #764 scoped to the footer: a sheet
footercontaining aTextInputand a siblingPressablecountingonPressIn/onPress— tap the input, dismiss the keyboard with the BACK key, tap the button once. With the fix the first tap fires; footer buttons and sheet drag/dismiss behave normally.Screenshots / Videos
N/A
Checklist