fix: return error responses for funding source without description_hash#140
Open
blackcoffeexbt wants to merge 1 commit into
Open
fix: return error responses for funding source without description_hash#140blackcoffeexbt wants to merge 1 commit into
blackcoffeexbt wants to merge 1 commit into
Conversation
…e that doesnt support description_hash e.g. Bark.
blackcoffeexbt
force-pushed
the
feat/funding_source_no_description_hash_improve_ux
branch
from
a89b25a to
3759ee3
Compare
dni
approved these changes
Jul 3, 2026
dni
changed the title
dni
reviewed
Jul 3, 2026
| funding_source = get_funding_source() | ||
| if ( | ||
| funding_source.features is not None | ||
| and not funding_source.has_feature(Feature.descriptionhash) |
Member
There was a problem hiding this comment.
there is no feature for Feature.descriptionhash? am i missing something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a clearer exception message when attempting to use LNURLp with a funding source that does not support description_hash (for example, Bark). Related to PR #4007. - lnbits/lnbits#4007
PRd Bark funding source support for this here @prusnak - prusnak/lnbits#1