Skip to content

fix(api): clean up bad JSON noise and fix progress bar going backwards #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lightningpixel merged 19 commits into from
Jun 20, 2026
+3 −2
Merged

fix(api): clean up bad JSON noise and fix progress bar going backwards #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
64a4330
fix(extension): manifest extensions error handle
lightningpixel May 10, 2026
af7c4a8
fix(architecture): terminate stale process runners on extension reins…
lightningpixel May 10, 2026
9b93b45
fix(architecture): purge stale generation jobs to prevent memory leak
lightningpixel May 10, 2026
a22c295
Add Wait node and conditional param visibility
Lorchie May 10, 2026
dde0bbb
fix(extensions): harden extension path handling
DrHepa May 10, 2026
f02b4b9
fix(extensions): rollback failed GitHub installs
DrHepa May 10, 2026
bb482e6
dump version 0.3.6
lightningpixel May 11, 2026
166788d
Merge pull request #139 from lightningpixel/release/v0.3.6
lightningpixel May 11, 2026
54285c7
Add social media links for Modly and Lightning Pixel
lightningpixel May 12, 2026
a9334df
Fix link formatting for Modly on X
lightningpixel May 12, 2026
11418dd
Update error logging for bad JSON input
iammojogo-sudo Jun 5, 2026
0920a1d
Fix progress callback to update job progress correctly
iammojogo-sudo Jun 5, 2026
091a808
Add sponsors section to README
lightningpixel Jun 5, 2026
c323008
Merge branch 'dev' into fix/progress-logging
iammojogo-sudo Jun 6, 2026
69015ea
Merge branch 'lightningpixel:main' into fix/progress-logging
iammojogo-sudo Jun 6, 2026
e2928cc
Downgrade version from 0.3.6 to 0.3.5
iammojogo-sudo Jun 9, 2026
341bd6e
Downgrade API version from 0.3.6 to 0.3.5
iammojogo-sudo Jun 9, 2026
6d6d12d
Revise README for Modly CLI and community info
iammojogo-sudo Jun 9, 2026
90344f8
Revert README changes unrelated to this PR
lightningpixel Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/routers/generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ async def _run_generation(job_id: str, image_bytes: bytes, params: dict, collect
job.status = "running"

def progress_cb(pct: int, step: str = "") -> None:
job.progress = pct
if pct > job.progress:
job.progress = pct
if step:
job.step = step

Expand Down
2 changes: 1 addition & 1 deletion api/services/extension_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def _read_loop(self, proc: subprocess.Popen, msg_queue: queue.Queue) -> None:
try:
msg_queue.put(json.loads(line))
except json.JSONDecodeError:
print(f"[{self.MODEL_ID}] bad JSON: {line}", file=sys.stderr)
print(f"[{self.MODEL_ID}] {line}", file=sys.stderr)
finally:
msg_queue.put(None) # sentinel: process is done

Expand Down