Skip to content

switch license headers#763

Open
liopeer wants to merge 2 commits into
mainfrom
lionel-small-license-fixes
Open

switch license headers#763
liopeer wants to merge 2 commits into
mainfrom
lionel-small-license-fixes

Conversation

@liopeer

@liopeer liopeer commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

What has changed and why?

  • fixing 2 license headers, which actually should be Lightly

Did you update CHANGELOG.md?

  • Yes
  • Not needed (internal change)

Did you update the documentation?

  • Yes
  • Not needed (internal change without effects for user)

Copilot AI review requested due to automatic review settings June 2, 2026 08:56
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@liopeer liopeer left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects license headers for two LT-DETR helper modules so they use the Lightly (repository) license header instead of the Apache 2.0 header, and updates the make add-header automation accordingly.

Changes:

  • Replaced the Apache 2.0 header with the Lightly header in two LT-DETR component files.
  • Updated Makefile’s add-header target to exclude those LT-DETR files from the RT-DETR Apache-header pass.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/lightly_train/_task_models/object_detection_components/ltdetr_schedule.py Switches file header to the Lightly license header.
src/lightly_train/_task_models/object_detection_components/ltdetr_geometry.py Switches file header to the Lightly license header.
Makefile Adjusts add-header to exclude the LT-DETR files from the RT-DETR header application.

Comment thread Makefile
Comment on lines +133 to +134
src/lightly_train/_task_models/object_detection_components/ltdetr_schedule.py \
src/lightly_train/_task_models/object_detection_components/ltdetr_geometry.py \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think copilot might be right here - we have this -x src/lightly_train/_task_models/object_detection_components for the default license header.

If there is no simple way to do this and you just added the license manually, then I think we can keep it as it is for now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a really "nice" way to do it, i.e. somehow make Lightly's license header the default that applies everywhere, where no exclusion rule exists. I now manually added them to the command that sets Lightly's license header.

@liopeer

liopeer commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

/review

@liopeer liopeer enabled auto-merge (squash) June 8, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants