switch license headers#763
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Pull request overview
This PR corrects license headers for two LT-DETR helper modules so they use the Lightly (repository) license header instead of the Apache 2.0 header, and updates the make add-header automation accordingly.
Changes:
- Replaced the Apache 2.0 header with the Lightly header in two LT-DETR component files.
- Updated
Makefile’sadd-headertarget to exclude those LT-DETR files from the RT-DETR Apache-header pass.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/lightly_train/_task_models/object_detection_components/ltdetr_schedule.py |
Switches file header to the Lightly license header. |
src/lightly_train/_task_models/object_detection_components/ltdetr_geometry.py |
Switches file header to the Lightly license header. |
Makefile |
Adjusts add-header to exclude the LT-DETR files from the RT-DETR header application. |
| src/lightly_train/_task_models/object_detection_components/ltdetr_schedule.py \ | ||
| src/lightly_train/_task_models/object_detection_components/ltdetr_geometry.py \ |
There was a problem hiding this comment.
I think copilot might be right here - we have this -x src/lightly_train/_task_models/object_detection_components for the default license header.
If there is no simple way to do this and you just added the license manually, then I think we can keep it as it is for now.
There was a problem hiding this comment.
I don't think there is a really "nice" way to do it, i.e. somehow make Lightly's license header the default that applies everywhere, where no exclusion rule exists. I now manually added them to the command that sets Lightly's license header.
|
/review |
What has changed and why?
Did you update CHANGELOG.md?
Did you update the documentation?