Add to_ace_string#446
Merged
james-d-mitchell merged 3 commits intoMay 30, 2026
Merged
Conversation
Joseph-Edwards
force-pushed
the
to-ace-string
branch
from
30f5ef0 to
c8aa2b3
Compare
Member
|
I think this looks good apart from the changes suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a function that can convert a presentation into ACE input. I am not 100% happy with the documentation here, because the function behaves differently (specifically, throws errors in different circumstances) dependent on whether it is called on a presentation over strings or words. I've tried to give a general idea of what might happen, but I'm keen to hear any suggestions on how to make it better. Should I be more verbose about what happens in the two cases, or is it fine as it is?