Repository navigation
Update CRL Profiles to match the detail of our Certificate Profiles - #360
Open
aarongable wants to merge 1 commit into
Open
aarongable wants to merge 1 commit into
aarongable wants to merge 1 commit into
Conversation
| | `revokedCertificates` | Present if and only if there is at least one revoked certificate entry | | ||
| | `serialNumber` | Byte-for-byte identical to the `serialNumber` of the revoked Certificate | | ||
| | `revocationDate` | The date and time at which ISRG recorded the Certificate as revoked, no later than `thisUpdate` | | ||
| | `crlEntryExtensions` | | |
Contributor
There was a problem hiding this comment.
Suggested change
| | `crlEntryExtensions` | | | |
| | `crlEntryExtensions` | Present if and only if there is at least one CRL entry extension, per RFC 5280 | |
This would be informational-only, because there is no choice being made by ISRG here. The spec requires a CRL to be encoded in this way. However, adding a note here makes it clearer to a reader lacking context of RFC 5280 that the crlEntryExtensions field may be absent.
(I did not add the same suggestion to the CA CRL Profile, because we always provide a reasonCode extension on their entries.)
Contributor
Author
There was a problem hiding this comment.
Yeah this is fair. I've also filed #361 both to comply with the upcoming CQRP and to make this kind of phrasing no longer necessary.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the level of detail and specificity in our CRL profiles, to match both the level of detail contained in the BRs and the level of detail we introduced for our Certificate profiles in #307.
This is a remediation item for https://bugzilla.mozilla.org/show_bug.cgi?id=2074944
Fixes #355