add mostly claude-gen usage example package - #43
Conversation
f050fb0 to
db8b0e6
Compare
f216f7d to
958d415
Compare
83e06cc to
1c2813a
Compare
1c2813a to
346bbb8
Compare
|
Why is there a client code added to the API? It belongs in a separate client package. Please submit this PR to https://github.com/lcls-users/lclstream.git |
|
Since there is CI involved, I would rather keep this all in the same repo. Eventually, I think we should migrate all of the fragmented packages we have in this org into a monorepo, it makes CI/CD much more straightforward, and allows us to suck up context for agents in one place rather than requiring people to manage their own workspace. This is a separate python package with a separate pyproject.toml - you can just refer to it differently in your dependencies ( |
|
If you want a super-repo, why not create a new one for that purpose and put all 4: lclstream_api, lclstream, lclstreamer, and fastcache into it as git submodules? |
|
submodules is a strategy for this, but i would argue not the best. it does not cover CI very well, and for each commit in a submodule, you have to make another commit to the submodule repo for every merge done in one of the submodules, another maintenance burden. it can also be quite confusing to work with i laid some of my arguments out for this in slack:
|
This is part 14 of 23 in a stack made with GitButler: