Repository navigation
Note v1 reviewing-surface placement in the ux design record - #92
Merged
Merged
Conversation
Screen 2 of the reviewing-surface record shows the importance, signals, asks and reviewed checkbox in a banner above the diff. v1 ships the asks in each part's context menu and the reviewed checkbox in the tree; note that in the record and point to issue #91 for the banner planned in v1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/ux/README.mdright after the screen 2 description of the reviewing-surface record: v1 ships the three asks in each part's context menu and the reviewed checkbox in the tree, rather than in the banner above the diff shown in the chosen mockup.docs/ux/reviewing-surface.html) are unchanged, and the root README already describes the asks in the part's context menu and the reviewed checkbox in the tree, so it needed no correction.Docs-only change;
npm run check(build, typecheck, lint, tests) passes.