-
Notifications
You must be signed in to change notification settings - Fork 3
feat!: Add ManagedResult, RunnerResult, and Runner protocol; rename invoke() to run() #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsonbailey
wants to merge
13
commits into
main
Choose a base branch
from
jb/aic-2388/managed-result
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5c4181c
feat!: Add ManagedResult, RunnerResult, and Runner protocol; rename i…
jsonbailey 4e28ae6
refactor: address review feedback on docstrings
jsonbailey 2dd9329
fix: merge duplicate track_tool_calls methods in LDAIConfigTracker
jsonbailey b4d15df
fix: avoid double metrics extraction in track_metrics_of helpers
jsonbailey 4fe7eb5
refactor: drop ModelRunner/AgentRunner compat from managed layer
jsonbailey ff871bf
fix: tighten _track_from_metrics_extractor checks
jsonbailey d75467f
refactor: remove deprecated ManagedModel.invoke()
jsonbailey 89d0ad7
refactor: type RunnerFactory.create_model/agent returns as Optional[R…
jsonbailey 7a52f24
refactor: handle metrics extraction failures gracefully
jsonbailey 45845ed
refactor: update Judge to use Runner protocol and RunnerResult
jsonbailey 56249a1
feat: Wire LDAIMetrics tool_calls and duration_ms into tracker
jsonbailey 4d86c9c
chore: remove stale PR-10 section comment from test_tracker.py
jsonbailey cc792ec
refactor: type metrics_extractor as Callable[[Any], Optional[LDAIMetr…
jsonbailey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| """Unified Runner protocol for AI providers.""" | ||
|
|
||
| from typing import Any, Dict, Optional, Protocol, runtime_checkable | ||
|
|
||
| from ldai.providers.types import RunnerResult | ||
|
|
||
|
|
||
| @runtime_checkable | ||
| class Runner(Protocol): | ||
| """ | ||
| Unified runtime capability interface for all AI provider runners. | ||
|
|
||
| A :class:`Runner` is a focused, configured object that performs a single | ||
| AI invocation. | ||
| """ | ||
|
|
||
| async def run( | ||
| self, | ||
| input: Any, | ||
| output_type: Optional[Dict[str, Any]] = None, | ||
| ) -> RunnerResult: | ||
| """ | ||
| Execute the runner with the given input. | ||
|
|
||
| :param input: The input to the runner. | ||
| :param output_type: Optional JSON schema for structured output. | ||
| :return: RunnerResult containing content, metrics, raw, and parsed fields. | ||
| """ | ||
| ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.