Skip to content

Fix failing tests - #1613

Merged
taylorotwell merged 2 commits into
laravel:5.xfrom
jasonmccreary:fix-jetstream-config-timing
Sep 17, 2026
Merged

taylorotwell merged 2 commits into
laravel:5.xfrom
jasonmccreary:fix-jetstream-config-timing

Conversation

@jasonmccreary

@jasonmccreary jasonmccreary commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

During #1612 I noticed the CI was failing. This PR fixes that.

The tests related to TestBench where the overrides landed too late, and so were hitting routes that never got registered. Addingdefer: false fixes it.

The other failing workflows now skips Composer's new advisory blocking when the stub-tests job spins up a fresh Laravel skeleton, since bumping that constraint is a separate issue.

@github-actions

Copy link
Copy Markdown

Thanks for submitting a PR!

Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@jasonmccreary
jasonmccreary force-pushed the fix-jetstream-config-timing branch from 08c320a to 0607551 Compare September 17, 2026 20:05
@jasonmccreary jasonmccreary changed the title Apply jetstream config in tests before routes boot Fix failing tests Sep 17, 2026
@jasonmccreary
jasonmccreary marked this pull request as ready for review September 17, 2026 20:16
@taylorotwell
taylorotwell merged commit 9b189b6 into laravel:5.x Sep 17, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants