Skip to content

[TINY] Switch to MeshData constructor instead of Initialize - #45

Merged
Yurlungur merged 4 commits into
mainfrom
lroberts36/remove-mesh-data-initialize
Oct 31, 2026
Merged

Yurlungur merged 4 commits into
mainfrom
lroberts36/remove-mesh-data-initialize

Conversation

@lroberts36

Copy link
Copy Markdown
Collaborator

PR Summary

Required to make Riot compile with Parthenon 1449.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the scripts/format.sh command or by using @par-hermes format
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • LANL employees: make sure tests pass both on the github CI and on the re-git CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.

Co-authored-by: Jonah Miller <DrLoco3000@gmail.com>
@Yurlungur
Yurlungur merged commit c81fc48 into main Oct 31, 2026
6 checks passed
@Yurlungur
Yurlungur deleted the lroberts36/remove-mesh-data-initialize branch October 31, 2026 15:55
@Yurlungur

Copy link
Copy Markdown
Collaborator

@lroberts36 sorry I got complacent. We should have run the regression tests before merging. This is causing the marshak test to fail. Can you investigate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants