[codex] Fix Langfuse hook cwd handling#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes unreliable automatic Codex Stop hook uploads by making the bundled hook command independent of the session working directory. Codex command hooks run with the session cwd, so the previous
node ./plugins/tracing/dist/index.mjscommand could resolve under arbitrary directories such as/private/tmpinstead of the plugin install location.What changed
${CODEX_HOME:-$HOME/.codex}/plugins/cache/codex-observability-plugin/tracing/0.1.0/dist/index.mjs.LANGFUSE_CODEX_FAIL_ON_ERROR/fail_on_errorso debugging runs can make upload and flush errors fail the hook instead of failing open..claudeworktree artifacts in Prettier checks.Validation
pnpm testpasses: 32 tests.pnpm run lint:tscpasses.pnpm run format:checkpasses.