Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-1.14.0 #15957 +/- ##
==================================================
- Coverage 70.93% 70.15% -0.79%
==================================================
Files 2812 2851 +39
Lines 304778 309494 +4716
Branches 41311 45267 +3956
==================================================
+ Hits 216198 217129 +931
- Misses 86081 89866 +3785
Partials 2499 2499
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
|
Build successful! ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds GitHub.com App installation connections for repository, issue, pull request, and comment actions, plus signed issue and pull request event triggers. Update actions preserve omitted fields. Trigger activation requires public HTTPS ingress and commits a cleanup reservation before remote setup, so a lost response or local rollback can be recovered. Cleanup verifies the recorded callback and blocks replacement until it finishes. Bot events are ignored by default to prevent action loops.
Depends on #15947. This branch includes the shared provider runtime prerequisite. The GitHub bundle, adapter, provider contract, release registration, and regression tests are included.
Verification
Tests ran at source head
9a79fa3f03630547c0881ceda1bea4f04035b72e, using the existing development environment withUV_NO_SYNC=1and the branch's source paths ahead of installed packages.PYTHONPATH=src/backend/base:src/lfx/src:src/bundles/github/src uv run --no-sync pytest src/backend/tests/unit/services/triggers/test_github_provider.py src/backend/tests/unit/services/triggers/test_github_lifecycle.py -q -o log_cli=false --tb=short --show-capture=nopassed 63 tests, including uncertain creation, local rollback, owner deletion, in-flight setup, and claimed cleanup.PYTHONPATH=src/lfx/src:src/bundles/github/src uv run --no-sync pytest -c src/bundles/github/pyproject.toml src/bundles/github/tests -q --tb=shortpassed 58 tests with backend imports blocked.PYTHONPATH=src/lfx/src:/private/tmp/le-3196-review-final-wheel-target uv run --no-sync pytest -c src/bundles/github/pyproject.toml src/bundles/github/tests -q --tb=shortpassed the same 58 tests against the installed wheel.src/frontend,npm test -- --runInBand src/pages/SettingsPage/pages/ConnectionsPage/__tests__/AddConnectionDialog.githubToken.test.tsxpassed 1 test. It submits the exact shared credential payload consumed by the backend service test, including required expiration and explicit background consent.uv run --no-sync pytest scripts/ci -q -o log_cli=false --tb=short --show-capture=nopassed 684 tests with 1 existing skip.uv run --no-sync scripts/ci/bundle_release_plan.py plan --base-ref origin/release-1.14.0 --head-ref HEAD --check --output /private/tmp/le3196-final-release-plan.jsonpassed for lfx-github 0.1.0.uv lock --check --offlineanduv run --no-sync scripts/ci/manage_bundle_profiles.py checkpassed.uv build src/bundles/github --wheel --out-dir /private/tmp/le-3196-review-final-distsucceeded. Installing that wheel in a temporary target discovered all ten components and the owned runtime entry point. Backend-free discovery passed with no backend modules imported.git diff --checkpassed.GitHub App repository permissions are enforced by GitHub on each endpoint. PATs and GitHub Enterprise are unsupported. Update nodes preserve empty text fields and do not support clearing them. Manual installation tokens require their actual expiration and expire within one hour. Renewal needs a rotating host resolver or connection recreation and trigger rebinding. Real GitHub installation and live webhook delivery remain unverified. Owner acceptance is pending.
Final review and verification addendum
uv run --no-sync pytest src/bundles/github/tests -q -o addopts= -o cache_dir=/private/tmp/le2477-palette-pytest— 68 passed from source and again against the rebuilt installed wheel. Real palette template construction covers every exported component; previous internal helper imports remain aliases.uv run --no-sync pytest -q -p no:cacheprovider src/backend/tests/unit/services/triggers/test_github_provider.py src/backend/tests/unit/services/triggers/test_github_lifecycle.py -k 'uncertain or rollback or cleanup or in_progress or superseded or consent or blocked'— 18 passed for uncertain setup, cleanup, ownership, consent, and policy refusal.The installed nine-provider validation passed 445 backend tests and built all 58 real component templates. The exact aggregate commands and shared-runtime results are recorded in #15947. Independent code, Python, and security review found no unresolved confirmed provider findings.
Source checkpoint:
eb2fa49383dc73be224f201eea2dd40792d99fa9. GitHub Actions CI, Mend scan, and PR checks.Real GitHub App installation and live webhook delivery remain unverified.
Verification after conflict resolution
The final head is 78dbdcebed. It includes the reviewed common changes from 7702a4a514 and the release squash 0b9eaeccdf. Its source tree matches tested merge 37745f8 exactly.
Merge conflicts are resolved. The provider contract entry and implementation were preserved. Shared files retain the reviewed response validation and audit fix, both sets of locale keys, and the approved label exceptions. Shared runtime regression results are recorded separately in #15947.
Provider runtime and lifecycle tests passed 63 tests. The CI script suite passed 716 tests with 1 skip. Backend tests used UV_PROJECT_ENVIRONMENT=/private/tmp/secret-sync-oss-venv, UV_CACHE_DIR=/private/tmp/open-pr-audit-20261023/uv-cache, and PYTHONPATH=src/backend/base:src/lfx/src:src/sdk/src:src/bundles/github/src.
Release planning and bundle profile checks passed. Commit hooks and secret scans passed.
GitHub reports no merge conflicts against the current release. New CI checks are still running. Live provider acceptance remains unverified.
Summary by CodeRabbit