Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughBoth JSON operations components now generate paths that preserve literal keys containing punctuation or other non-identifier characters. A parametrized test checks path generation and selection for varied key formats. ChangesJSON Path Selection
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
|
CI follow-up for caa8b60: the main run failed in the frontend Jest job, in The failing job is https://github.com/langflow-ai/langflow/actions/runs/38992625938/job/117278191819 . This PR changes the Python path generators, their regression tests and cached templates. I have not reproduced the frontend failure locally, so I am recording it separately rather than claiming the overall CI passed. |
Preserve current upstream changes and regenerate only this PR's component cache entries.
Path Selection concatenates object keys into jq programs. A literal key such as
document.idbecomes.document.id, which can silently select a different nested field; spaces, quotes, backslashes and leading digits can instead produce invalid jq.Keep ordinary ASCII jq identifiers unchanged and JSON-encode other keys before constructing paths. Apply the same rule to Operations and legacy JSON Operations, preserve array indexing, and update only their two cached source/hash entries.
Fixes #15831.
Validation on current release-1.13.0 (
ddaf568f866af3f594efc0c64709c262f0e18f08): 224 passed, 8 skipped across the two complete component test files, including real libjq selection for special keys and ordinary-key controls. Skips are inherited historical-version fixture checks. Official two-component cache generation/integrity validation and all applicable pre-commit checks pass. All other catalog entries and current upstream component changes are preserved. Frozen lfx/backend dev dependencies and imports from the synchronized checkout were verified. No full backend, frontend, provider or connected-graph suite was run locally.This head merges the current release baseline and preserves existing history. Its upstream CI is tracked separately; the old head's unrelated frontend Jest failure is historical and is not a claim about this new run.
AI assistance: Codex was used for investigation, implementation, regression tests and upstream synchronization.