fix(deps): update rust crate sqlx to 0.9#94
Conversation
|
Deploying koyori with
|
| Latest commit: |
b71dbcd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://533ac239.koyori.pages.dev |
| Branch Preview URL: | https://renovate-sqlx-0-x.koyori.pages.dev |
208d63e to
e461b46
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthroughバックエンドの ChangesSQLx 依存関係アップグレード
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/backend/Cargo.toml`:
- Line 56: The dependency line sqlx = { version = "0.9", features =
["runtime-tokio-rustls", "postgres", "time"] } requires MSRV 1.94.0, so add
rust-version = "1.94.0" to the same Cargo.toml containing that sqlx entry and
also pin the CI toolchain (create or update rust-toolchain.toml or set the
dtolnay/rust-toolchain action to channel 1.94.0) so CI uses Rust 1.94.0
consistently; ensure changes reference the existing sqlx declaration and the
rust-version key to make the MSRV explicit.
- Line 56: The public APIs in jobs (e.g., the connect/setup functions referenced
in apps/backend/src/jobs/mod.rs and apps/backend/src/jobs/github_webhook.rs)
expose Result<..., sqlx::Error>, which can clash because apalis-postgres pulls
sqlx 0.8 while the crate uses sqlx 0.9; change those function signatures to
return a non-sqlx public error type (for example anyhow::Error or Box<dyn
std::error::Error + Send + Sync>) or the apalis_postgres-specific error type,
and map/convert any internal sqlx errors to that chosen type before returning
(use .map_err(|e| e.into() / anyhow::Error::from(e)) in the connect/setup and
related functions so callers never see sqlx::Error across the crate boundary).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3a24f089-ce72-475d-bfbd-d114de36b944
📒 Files selected for processing (1)
apps/backend/Cargo.toml
e461b46 to
1bb6dff
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
apps/backend/Cargo.toml (1)
56-56:⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift既存の主要な懸念事項が未解決のまま、SQLx 0.9 の破壊的変更による影響確認が必要です
過去のレビューで指摘された2つの重大な問題(MSRV 1.94.0 の未設定、
apalis-postgresとの sqlx バージョン競合)が未解決です。さらに、PR の説明に記載されている SQLx 0.9 の破壊的変更(query*()のSqlStr要件、Migrateトレイトの変更、型・ライフタイムパラメータの調整、Postgres 固有の動作変更)がコードベースに影響を与えないか確認が必要です。以下のスクリプトで、sqlx 0.9 へのアップグレード後もコンパイルとテストが通るか検証してください:
#!/bin/bash set -euo pipefail echo "== Cargo.toml の sqlx バージョン確認 ==" rg -n 'sqlx.*version' apps/backend/Cargo.toml echo echo "== cargo check でコンパイル確認 ==" cd apps/backend cargo check 2>&1 | head -100 echo echo "== 依存関係の競合確認(sqlx 0.8 と 0.9 の混在) ==" cargo tree -p sqlx 2>&1 | head -50🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/backend/Cargo.toml` at line 56, The Cargo.toml upgrade to sqlx = "0.9" may break build and conflicts with apalis-postgres and MSRV requirements; run the provided verification script in the repository root to (1) confirm the sqlx version entry in apps/backend/Cargo.toml, (2) run cargo check in apps/backend to surface compile errors caused by sqlx 0.9 breaking changes (e.g., query*() requiring SqlStr, Migrate trait signature changes, type/lifetime parameter adjustments, Postgres-specific behavior), and (3) inspect cargo tree -p sqlx to detect mixed 0.8/0.9 dependencies and apalis-postgres version mismatches; if issues appear, either pin sqlx back to a compatible 0.8 version or update dependent crates (including apalis-postgres) and adjust code paths that use query*(), Migrate implementations, and any Postgres-specific APIs to the sqlx 0.9 signatures, and ensure MSRV is set to >=1.94.0 in CI/toolchain configuration.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@apps/backend/Cargo.toml`:
- Line 56: The Cargo.toml upgrade to sqlx = "0.9" may break build and conflicts
with apalis-postgres and MSRV requirements; run the provided verification script
in the repository root to (1) confirm the sqlx version entry in
apps/backend/Cargo.toml, (2) run cargo check in apps/backend to surface compile
errors caused by sqlx 0.9 breaking changes (e.g., query*() requiring SqlStr,
Migrate trait signature changes, type/lifetime parameter adjustments,
Postgres-specific behavior), and (3) inspect cargo tree -p sqlx to detect mixed
0.8/0.9 dependencies and apalis-postgres version mismatches; if issues appear,
either pin sqlx back to a compatible 0.8 version or update dependent crates
(including apalis-postgres) and adjust code paths that use query*(), Migrate
implementations, and any Postgres-specific APIs to the sqlx 0.9 signatures, and
ensure MSRV is set to >=1.94.0 in CI/toolchain configuration.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e9ffbdff-e52a-40fb-b04b-4fe96b1d928c
📒 Files selected for processing (1)
apps/backend/Cargo.toml
d6f0ce1 to
1beedb7
Compare
|
User renovate[bot] does not have write permissions |
ae4cc72 to
c5226e5
Compare
|
User renovate[bot] does not have write permissions |
c5226e5 to
45941d5
Compare
|
User renovate[bot] does not have write permissions |
45941d5 to
a9f17fc
Compare
|
User renovate[bot] does not have write permissions |
a9f17fc to
d55d995
Compare
|
User renovate[bot] does not have write permissions |
d55d995 to
629d030
Compare
|
User renovate[bot] does not have write permissions |
08ae086 to
7ad1a02
Compare
This PR contains the following updates:
0.8→0.9Configuration
📅 Schedule: (in timezone Asia/Tokyo)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.