feat(frontend): implement real API for task table page#244
Draft
sousuke0422 wants to merge 6 commits into
Draft
Conversation
- Replace inline mock data with real API queries via fetchClient
- Implement query flow: list_projects → find project_id → parallel list_tasks + list_statuses
- After tasks resolve, fetch list_assignees per task via Promise.all
- Resolve status_id → {name, color} from statuses list via Map
- Assignee: UUID stub display (grey circle + ? icon) with console.log + TODO
- Update PRIORITY_CONFIG for all API TaskPriority values (CriticalFire..Trivial)
- due_date uses tasks.Model.soft_deadline
- Remove all Date.now()/new Date() mock data
- Update Storybook to fetch mock pattern (like MyTasks.stories.ts)
- Add stories: WithTasks, Empty, ApiError, Loading, Sorting
Assisted-by: multi-agent-shogun-aki-tweak
Coverage Report for apps/frontend
File CoverageNo changed files found. |
|
Important UI Tests need review – Review now🟡 UI Tests: 5 changes must be accepted as baselines |
|
コードを確認しました。以下の指摘があります。 High
|
Assisted-by: multi-agent-shogun-aki-tweak
Deploying koyori with
|
| Latest commit: |
87d2760
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b4b2f26c.koyori.pages.dev |
| Branch Preview URL: | https://feat-task-table-real-api.koyori.pages.dev |
…, chromatic baseline) - [medium] remove as any cast for list_tasks params by using regenerated openapi types and adding non-null assertions for projectId - [low] refactor Empty story to self-contained fetch mock (no mockFetch dependency) - [low] change isInitialLoading from isFetching to isLoading, add rationale comment - [cmd_394] rename WithTasks export to Default for Chromatic baseline restoration Assisted-by: multi-agent-shogun-aki-tweak
… task table - TaskRow.assignee_user_ids: string[] for multi-assignee support - Overlapping avatars with ring-2 ring-background (OriginUI comp-409 style) - +M overflow chip for avatars exceeding display limit (default 3) - "先頭名 他N名" text label for 2+ assignees - Storybook: add task-6 with 5 assignees for overflow test coverage Assisted-by: multi-agent-shogun-aki-tweak
…e cell - Create reusable AvatarGroup.vue component (comp-409 +N chip + comp-412 compact size) - Props: userIds, maxDisplay (default 3) - Replace inline h() implementation in TaskTable assignee column - Size: 28px (size-7) with ring-2 ring-background overlap effect - Keep "先頭名 他N名" text per lord instruction - Keep TODO comment for future user name resolution API Assisted-by: multi-agent-shogun-aki-tweak
Root cause: both task-1 (3 users, maxDisplay=3) and task-6 (5 users, maxDisplay=3) showed +2 text due to fallback logic, causing Chromatic findByText to match multiple elements. Fix 1: AvatarGroup.vue - show overflow text only when remaining > 0 Fix 2: TaskTable.stories.ts - update play function comment to reference task-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
実際のapiを使うように。
ついでにsbに毎日差分出るの予防。