Skip to content

Kong1dot1#38

Open
mtmail wants to merge 1 commit into
kontena:masterfrom
mtmail:kong1dot1
Open

Kong1dot1#38
mtmail wants to merge 1 commit into
kontena:masterfrom
mtmail:kong1dot1

Conversation

@mtmail

@mtmail mtmail commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Splits /apis endpoint into /routes and /services that Kong 1.0 introduced. We're running this fine for 6 months now. First Kong 1.1, currently Kong 1.4

@mtmail

mtmail commented Nov 20, 2019

Copy link
Copy Markdown
Contributor Author

I split off the Travis and rubocop fixes into separate PRs.

@irfn

irfn commented Dec 11, 2019

Copy link
Copy Markdown

@mtmail @nevalla This is a very useful PR. Is there anything blocking this?

@irfn

irfn commented Dec 11, 2019

Copy link
Copy Markdown

@mtmail if you are using this rt now, is there a gem version published somewhere?

@irfn

irfn commented Dec 12, 2019

Copy link
Copy Markdown

@mtmail i was not able to add upstreams for using this and getting
Kong::Error ({"message":"schema violation (upstream_id: unknown field)","name":"schema violation","fields":{"upstream_id":"unknown field"},"code":2})

the docs show target structure has changed https://docs.konghq.com/1.4.x/admin-api/#add-target

@irfn

irfn commented Dec 12, 2019

Copy link
Copy Markdown

@mtmail

This is a workaround i am doing to make this work
irfn@a0ee591
hope you can address this.

@irfn

irfn commented Dec 12, 2019

Copy link
Copy Markdown

Actually ignore the above workaround. It only allows you to create and not view.
Here i have updated this to handle update & view (still workaround quality)

irfn@758974e

@arthurmde

Copy link
Copy Markdown
Contributor

@mtmail @irfn sometimes it seems like this gem is not being maintained anymore, but I'm not sure. Did you publish your fork publicly in the Rubygems?

Do you intend to maintain a fork to let it updated with new Kong versions? I'm interested to help.

@nevalla

nevalla commented Dec 17, 2019

Copy link
Copy Markdown
Contributor

Hi, sorry for not giving any feedback here. Finally, I have now time to push this further. So, I'll test this out with the latest version of Kong and review the PR.

After we get this merged I'll create a beta/rc build so you can test it too.

@nevalla

nevalla commented Dec 17, 2019

Copy link
Copy Markdown
Contributor

Please could you rebase and resolve conflicts. Meta PRs are now merged so it would be easier to review this PR.

@mtmail mtmail force-pushed the kong1dot1 branch 2 times, most recently from a0b8b01 to c782bbc Compare December 17, 2019 14:42
@mtmail

mtmail commented Dec 17, 2019

Copy link
Copy Markdown
Contributor Author

I split off the bundler,rake changes into a separate PR #42

@irfn

irfn commented Dec 17, 2019

Copy link
Copy Markdown

@mtmail do you intend to work on Kong 1.4.x support? I mentioned the issue in the thread.

@mtmail

mtmail commented Dec 17, 2019

Copy link
Copy Markdown
Contributor Author

@irfn I'm using this library with 1.4.0 already, I guess not the feature you mention. Can you create a separate github issue?

@mtmail

mtmail commented Dec 17, 2019

Copy link
Copy Markdown
Contributor Author

Rebased, squashed, and tests passing. I set version to 0.4.0 and added a changelog entry.

@irfn

irfn commented Dec 19, 2019

Copy link
Copy Markdown

@irfn I'm using this library with 1.4.0 already, I guess not the feature you mention. Can you create a separate github issue?

Ill retest and raise issue once this is merged. thanks!

@YusukeIwaki

Copy link
Copy Markdown

Any update?

We are really looking forward to use Kong::Service and working Kong::JWT :)

@mtmail

mtmail commented Dec 11, 2020

Copy link
Copy Markdown
Contributor Author

My fork works with Kong 2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants