Upgrade operator to Fabric-X components v1.0.0 - #3
Open
elishambadi wants to merge 3 commits into
Open
elishambadi wants to merge 3 commits into
elishambadi wants to merge 3 commits into
Conversation
added 3 commits
July 27, 2026 14:12
- update templates.go & config/samples to reflect new versions - update to fabric-x-common v 0.2.6 - add consenters to genesis block in genesis_service.go - add configurable PVC sizes to configs - in shared_config.go. Ensure RequestBatchMaxBytes > RequestMaxBytes
- Implement unit tests for the BlockExplorer controller, covering both 'configure' and 'deploy' modes. - Ensure the tests validate the creation of necessary Kubernetes resources such as secrets and deployments. - Introduce BlockExplorerTemplateData struct and BuildBlockExplorerConfig function to generate block explorer configuration. - Update the templates.go file to include the new configuration generation logic.
Contributor
|
@elishambadi thanks for putting this upgrade together. I’m requesting changes because I found several blocking issues:
I also found invalid storage input reaching Focused genesis and BlockExplorer tests passed, but the QueryService tests failed, GitHub reports no CI checks, and the PR contains no runtime deployment evidence. Please address these issues and add an end-to-end reconciliation test that runs at least twice to verify steady-state behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Summary
Changes made: