Implement BYSETPOS support for monthly recurrence rules with BYMONTHDAY#985
Open
mschroeder wants to merge 1 commit into
Open
Implement BYSETPOS support for monthly recurrence rules with BYMONTHDAY#985mschroeder wants to merge 1 commit into
mschroeder wants to merge 1 commit into
Conversation
kewisch
approved these changes
Jun 2, 2026
kewisch
left a comment
kewisch
left a comment
Owner
There was a problem hiding this comment.
Spectacular, thanks for tackling this Martin. Good to see you're still following :)
Some minor comments if you could take a look
| let day = this._findByMonthDaySetPos(this.last.day + 1); | ||
| let attempts = 0; | ||
|
|
||
| while (!day && attempts++ < 48) { |
Owner
There was a problem hiding this comment.
Could you add a comment on why 48 attempts, here and in the last function?
Comment on lines
+808
to
+810
| if (this.has_by_data("BYSETPOS")) { | ||
| data_valid = this._nextMonthlyByMonthDaySetPos(); | ||
| } else { |
Owner
There was a problem hiding this comment.
Have you considered cases where we have BYMONTHDAY, BYSETPOS, and other rule parts? I think theoretically a BYDAY could appears as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #960