Add SoraRaw#16570
Conversation
Rafou376
left a comment
Rafou376
left a comment
There was a problem hiding this comment.
Think about rereading CONTRIBUTING.md
| val author: String? = null, | ||
| val artist: String? = null, | ||
| val status: String? = null, | ||
| val genres: List<kotlinx.serialization.json.JsonElement>? = null, |
There was a problem hiding this comment.
why JsonElement? also import
There was a problem hiding this comment.
The genres JSON is different depending on the endpoint. On list/search it returns IDs [368, 511], but on details it returns objects [{"id": 16, "name": "18禁"}]. Since MangaDto is shared, I used JsonElement to handle both. I also fixed the import.
| } | ||
| } | ||
|
|
||
| return getFullDatabaseObservable().map { list -> |
There was a problem hiding this comment.
if website doesn't provide proper search, then don't provide one, instead of fetching 100 pages in one go
There was a problem hiding this comment.
The site itself uses client-side search and fetches until 404, so removing search makes the extension useless imo. I replaced the 1..100 loop with a dynamic fetch that stops on 404 (page 12, as there are 11 JSON files). The results are cached in memory so it only fetches once per session. Can it be like this?
3 participants
Support for https://soraraw.net/ or https://soraraw.com/ (#10972)
extVersionCodevalue inbuild.gradlefor individual extensions (Set to1for the new extension)overrideVersionCodeorbaseVersionCodeas needed for all multisrc extensions (N/A for individual extension)isNsfw = trueflag inbuild.gradlewhen appropriate (Set totrue)idif a source's name or language were changed (N/A for new extension)web_hi_res_512.pngwhen adding a new extension