feat: handle CRD lifecycle in helm backend chart#591
Open
alokkumardalei-wq wants to merge 1 commit into
Open
Conversation
Fixes kbind-dev#404 by moving CRDs to templates and guarding with crds.install flag. Signed-off-by: alokkumardalei-wq <alokkumardalei2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #404.
Currently, CRDs are placed in the crds/ folder of the backend chart, meaning they are only applied on helm install and ignored during helm upgrade. This PR shifts CRDs to the templates/ folder to enable a proper lifecycle and allow users to upgrade CRDs seamlessly alongside backend updates.
Changes:
Warning
Because CRDs are now managed as standard templates, running
helm uninstallon this chart will delete the CRDs and subsequently delete all instances of those Custom Resources in the cluster.Testing & Verification: