Repository navigation
Fall back when the byte array buffer pool is exhausted - #515
Merged
Merged
Conversation
acquire() returned pool.poll() directly, so once every pooled buffer was in use the Kotlin null check threw "poll(...) must not be null". Keep the pool's buffer size and allocate a fresh buffer of that size instead.
Contributor
em3s
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ByteArrayBufferPool.acquire()throws a NullPointerException when all pooled buffers are in use. This can be reproduced by nestingusecalls on a pool withpoolSize = 1. Allocate a buffer of the configured size when the pool is empty, following the approach used for codec-java in #506.Changes
How to Test
./gradlew :core:test --tests '*ByteArrayBufferPoolTest': both regression tests fail before the fix and pass afterward../gradlew spotlessCheck build --continue: formatting checks passed. The full build did not pass because engine tests encountered local HBase mini-cluster startup failures.AI Assistance