Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -404,11 +404,15 @@ public String useAsHexString(Consumer<EdgeBuffer> block) {

public byte[] useAsByteArray(Consumer<EdgeBuffer> block) {
EdgeBuffer edgeBuffer = borrow();
edgeBuffer.reset();
block.accept(edgeBuffer);
byte[] byteArray = edgeBuffer.buffer.toByteArray();
release(edgeBuffer);
return byteArray;
try {
edgeBuffer.reset();
block.accept(edgeBuffer);
return edgeBuffer.buffer.toByteArray();
} finally {
if (edgeBuffer != null) {
release(edgeBuffer);
}
}
}

// --- private
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
package com.kakao.actionbase.v2.core.code;

import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertSame;
import static org.junit.jupiter.api.Assertions.assertThrows;

import org.junit.jupiter.api.Test;

class AbstractEdgeEncoderTest {

@Test
void shouldReturnBorrowedBufferAfterEncodingFails() {
EdgeEncoderFactory factory = new EdgeEncoderFactory(1);
BytesKeyValueEdgeEncoder encoder = factory.getBytesKeyValueEncoder();
EdgeBuffer borrowed = factory.pool.peek();

IllegalArgumentException failure =
assertThrows(
IllegalArgumentException.class,
() ->
encoder.useAsByteArray(
buffer -> {
buffer.encodeInt8((byte) 7);
buffer.encodeAny(new Object());
}));

assertEquals("Unexpected data of type : java.lang.Object", failure.getMessage());
assertEquals(1, encoder.getPoolSize());
assertSame(borrowed, factory.pool.peek());

byte[] encoded = encoder.useAsByteArray(buffer -> buffer.encodeInt8((byte) 1));
byte[] expected =
new EdgeEncoderFactory()
.getBytesKeyValueEncoder()
.useAsByteArray(buffer -> buffer.encodeInt8((byte) 1));
assertArrayEquals(expected, encoded);
assertSame(borrowed, factory.pool.peek());
}
}
Loading