fix(misc): k0sctl migration findings

[kke]

• The Pipe() helper shell-escapes all arguments via shellescape.Quote, so passing -d"=" produced '-d"="' on the wire, causing cut to receive a three-character delimiter and fail with "the delimiter must be a single character". Use -d= directly, the equals sign needs no shell quoting.
• DaemonReload no longer exposed via the service wrapper, the caller must know to call the service manager's DaemonReload instead of all callers being forced to call it even-though it's a no-op on all but one of the init systems.
• UpdateServiceEnvironment returned an error instead of setting service environment variables on windows, which is now done via registry.
• Remove the http.RoundTripper invention for now - replace with an universal client.Dial(..) later.

Breaking API is not a problem, the v2 API hasn't been released yet.

[Copilot]

Pull request overview

This PR addresses several migration findings by improving cross-platform service management (especially on Windows), fixing a systemd command quoting bug, and simplifying remote HTTP probing by removing the previous http.RoundTripper-style implementation from remotefs.

Changes:

• Fix systemd service script path resolution by adjusting cut -d argument usage to avoid over-quoting.
• Make Service.DaemonReload() a no-op when unsupported, and add a Windows SCM path to set service environment variables via registry.
• Remove the remotefs HTTP transport/RoundTripper approach and replace it with a simpler HTTPStatusInsecure probe API.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
service.go	Adds direct env setting via ServiceEnvironmentSetter and makes DaemonReload a no-op when unsupported.
service_test.go	Adds tests for the new env-setter path and updates daemon-reload expectations.
remotefs/winfs.go	Removes RoundTripper implementation and introduces Windows HTTP status probing via PowerShell.
remotefs/winfs_test.go	Removes old HTTP status test tied to the former RoundTripper behavior.
remotefs/upload_test.go	Updates test FS stubs to reflect removal of RoundTripper from the FS interface.
remotefs/types.go	Replaces HTTPTransport embedding with a narrower Downloader interface.
remotefs/posixfs.go	Removes RoundTripper implementation and introduces curl-based HTTP status probing.
remotefs/posixfs_test.go	Removes old HTTP status tests tied to the former RoundTripper behavior.
remotefs/patchfile_test.go	Updates test FS stubs to reflect removal of RoundTripper from the FS interface.
remotefs/http.go	Replaces old HTTP transport helpers with HTTPStatusInsecure + provider interface.
remotefs/http_test.go	Replaces extensive RoundTripper tests with targeted HTTPStatusInsecure tests.
initsystem/winscm.go	Implements Windows service environment updates via registry (MultiString Environment).
initsystem/winscm_test.go	Adds coverage for Windows SCM environment registry updates.
initsystem/systemd.go	Fixes cut delimiter arg to avoid Pipe() over-quoting issues.
initsystem/defaultprovider.go	Introduces ServiceEnvironmentSetter interface for direct env-setting implementations.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

[twz123]

DaemonReload should be a no-op on systems that do not have such mechanism (windows)

Wouldn't it be more appropriate to return EWINDOWS or something that is errors.ErrUnsupported, so that callers will know if something actually happened? They can still opt to ignore that error, if that's okay.

[kke]

Wouldn't it be more appropriate to return EWINDOWS or something that is errors.ErrUnsupported, so that callers will know if something actually happened? They can still opt to ignore that error, if that's okay.

It's not windows specific, Systemd is the only one that implements the ServiceManagerReloader interface, OpenRC, runit, upstart, launchd, and whatever there is, don't.

Optimally callers wouldn't need to call it in the first place. The DaemonReload is just mechanics of one init system, sort of an implementation detail when operating with systemd units.

I think the caller doesn't actually care if it worked or "did nothing by design" when the expected happy path result is simply "after I run this, I can start the service, unless it reports an error".

The EWINDOWS / ErrUnsupported would require you to always call it like:

if err := h.DaemonReload(...); err != nil {
  if !errors.Is(err, rig.ErrUnsupported) {
     return err
  }
  // ignore ErrUnsupported
}

I think returning "unsupported" in this case would be more like ErrThanksForCalling.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

[kke]

Maybe the caller shouldn't be calling it.

They can do an interface check on the servicemanager instance and call it. The "wrapper" doesn't need to expose it.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.