Fix spurious surface.requiresWithoutDeferred for qualified deferred names (#26)#30
Merged
Merged
Conversation
…ames (#26) findSurfaceRequiresDeferredHintIssues collected deferred names with a dot-only pattern, so `deferred billing/InvoiceWorkflow` registered only `billing` and a `requires InvoiceWorkflow:` clause was warned as having no deferred hint. The pattern now accepts module-qualified names and registers the unqualified form alongside the full name, while the alias alone no longer satisfies the match. Also documents the matching semantics in the extension behaviour spec and flags the porting note in the Rust parity doc, since the Rust checker has no equivalent check yet. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26.
findSurfaceRequiresDeferredHintIssuescollected deferred names with the dot-only pattern/^\s*deferred\s+([A-Za-z_][A-Za-z0-9_.]*)\b/gm, sodeferred billing/InvoiceWorkflowregistered onlybilling. A surface clauserequires InvoiceWorkflow:then failed the name match and emitted a spuriousallium.surface.requiresWithoutDeferredwarning.Changes
/, and module-qualified names register both the full name and the unqualified part after the alias. As a side effect, the alias alone (requires billing:) no longer silently satisfies the match — that was a false negative before.allium-extension-behaviour.alliumand added a porting note torust-checker-parity.md, since the Rust checker has no equivalent check yet (the parity hazard flagged in the issue).Testing
All workspace tests pass (309 extension + 8 LSP, 0 failures).
🤖 Generated with Claude Code